| Message ID | 20210927154159.2168500-4-robert.marko@sartura.hr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] arm64: dts: marvell: espressobin-ultra: enable UART output by default | expand |
On Monday 27 September 2021 17:41:59 Robert Marko wrote: > Espressobin Ultra has a front panel USB3.0 Type-A port which works > just fine so enable it. > I dont see a reason why it was disabled in the first place anyway. If USB 3.0 port is was tested and is working fine, then what about adding Fixes: tag into commit message? > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > --- > arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > index 96855a10b4a0..aada43fa236c 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > @@ -112,7 +112,6 @@ rtc@51 { > > &usb3 { > usb-phy = <&usb3_phy>; > - status = "disabled"; > }; > > &mdio { > -- > 2.31.1 >
On Tue, Sep 28, 2021 at 5:37 PM Pali Rohár <pali@kernel.org> wrote: > > On Monday 27 September 2021 17:41:59 Robert Marko wrote: > > Espressobin Ultra has a front panel USB3.0 Type-A port which works > > just fine so enable it. > > I dont see a reason why it was disabled in the first place anyway. > > If USB 3.0 port is was tested and is working fine, then what about > adding Fixes: tag into commit message? Sure, gotta send a v4 anyway dropping the first patch. Regards, Robert > > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > > --- > > arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > > index 96855a10b4a0..aada43fa236c 100644 > > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > > @@ -112,7 +112,6 @@ rtc@51 { > > > > &usb3 { > > usb-phy = <&usb3_phy>; > > - status = "disabled"; > > }; > > > > &mdio { > > -- > > 2.31.1 > >
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts index 96855a10b4a0..aada43fa236c 100644 --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts @@ -112,7 +112,6 @@ rtc@51 { &usb3 { usb-phy = <&usb3_phy>; - status = "disabled"; }; &mdio {
Espressobin Ultra has a front panel USB3.0 Type-A port which works just fine so enable it. I dont see a reason why it was disabled in the first place anyway. Signed-off-by: Robert Marko <robert.marko@sartura.hr> --- arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 1 - 1 file changed, 1 deletion(-)