| Message ID | 20220906135511.144725-2-sergiu.moga@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Make atmel serial driver aware of GCLK | expand |
On Tue, Sep 06, 2022 at 04:55:00PM +0300, Sergiu Moga wrote: > The DT nodes of the SPI IP's may contain DMA related properties so > make sure that the binding is able to properly validate those as > well by making it aware of these optional properties. Acked-by: Mark Brown <broonie@kernel.org> though it looks like perhaps this could just go separately?
On Tue, 06 Sep 2022 16:55:00 +0300, Sergiu Moga wrote: > The DT nodes of the SPI IP's may contain DMA related properties so > make sure that the binding is able to properly validate those as > well by making it aware of these optional properties. > > Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com> > --- > > > v1 -> v2: > - Nothing, this patch was not here before > > > .../devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ spi@400: dma-names:0: 'tx' was expected arch/arm/boot/dts/at91-sama7g5ek.dtb spi@400: dma-names:1: 'rx' was expected arch/arm/boot/dts/at91-sama7g5ek.dtb spi@400: Unevaluated properties are not allowed ('dma-names' was unexpected) arch/arm/boot/dts/at91-sama7g5ek.dtb
On 07.09.2022 00:41, Rob Herring wrote: > > On Tue, 06 Sep 2022 16:55:00 +0300, Sergiu Moga wrote: >> The DT nodes of the SPI IP's may contain DMA related properties so >> make sure that the binding is able to properly validate those as >> well by making it aware of these optional properties. >> >> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com> >> --- >> >> >> v1 -> v2: >> - Nothing, this patch was not here before >> >> >> .../devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > spi@400: dma-names:0: 'tx' was expected > arch/arm/boot/dts/at91-sama7g5ek.dtb > > spi@400: dma-names:1: 'rx' was expected > arch/arm/boot/dts/at91-sama7g5ek.dtb > > spi@400: Unevaluated properties are not allowed ('dma-names' was unexpected) > arch/arm/boot/dts/at91-sama7g5ek.dtb > Hi, This should be solved by the next patch of this series. I guess this yaml property addition should have come after the DTS fix patch.
On 06/09/2022 15:55, Sergiu Moga wrote: > The DT nodes of the SPI IP's may contain DMA related properties so > make sure that the binding is able to properly validate those as > well by making it aware of these optional properties. > > Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml index d85d54024b2e..4dd973e341e6 100644 --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml @@ -34,6 +34,16 @@ properties: clocks: maxItems: 1 + dmas: + items: + - description: TX DMA Channel + - description: RX DMA Channel + + dma-names: + items: + - const: tx + - const: rx + atmel,fifo-size: $ref: /schemas/types.yaml#/definitions/uint32 description: |
The DT nodes of the SPI IP's may contain DMA related properties so make sure that the binding is able to properly validate those as well by making it aware of these optional properties. Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com> --- v1 -> v2: - Nothing, this patch was not here before .../devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)