diff mbox series

[v2,2/3] ARM: dts: imx6: pfla02: Rely on PMIC reboot/reset handler

Message ID 20230719114328.2239818-2-andrej.picej@norik.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/3] ARM: dts: imx6: phytec: fix RTC interrupt level | expand

Commit Message

Andrej Picej July 19, 2023, 11:43 a.m. UTC
Due to the missing signal connection between i.MX6 WDOG_B pin and the
PMICs external reset, the internal i.MX6 watchdog is not able to reset
the phyFLEX SoM properly. Thus disable the internal i.MX6 watchdog to
prevent unexpected PMIC settings after reset.

NOTE: This patch should not be backported as it might break existing
uses and fixes in bootloaders.

Signed-off-by: Andrej Picej <andrej.picej@norik.com>
---
Changes in v2:
 - this is a substitute patch with a proper fix.
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Stefan Riedmüller July 19, 2023, 11:50 a.m. UTC | #1
Hi Andrej,

On Wed, 2023-07-19 at 13:43 +0200, Andrej Picej wrote:
> Due to the missing signal connection between i.MX6 WDOG_B pin and the
> PMICs external reset, the internal i.MX6 watchdog is not able to reset
> the phyFLEX SoM properly. Thus disable the internal i.MX6 watchdog to
> prevent unexpected PMIC settings after reset.
> 
> NOTE: This patch should not be backported as it might break existing
> uses and fixes in bootloaders.
> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>

Reviewed-by: Stefan Riedmüller <s.riedmueller@phytec.de>

> ---
> Changes in v2:
>  - this is a substitute patch with a proper fix.
> ---
>  arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
> b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
> index 80adb2a02cc9..65fd7b4a6f27 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
> @@ -464,3 +464,11 @@ &usdhc3 {
>         vmmc-supply = <&vdd_sd0_reg>;
>         status = "disabled";
>  };
> +
> +&wdog1 {
> +       /*
> +        * Rely on PMIC reboot handler. Internal i.MX6 watchdog, that is
> also
> +        * used for reboot, does not reset all external PMIC voltages on
> reset.
> +        */
> +       status = "disabled";
> +};
Shawn Guo July 30, 2023, 6:41 a.m. UTC | #2
On Wed, Jul 19, 2023 at 01:43:27PM +0200, Andrej Picej wrote:
> Due to the missing signal connection between i.MX6 WDOG_B pin and the
> PMICs external reset, the internal i.MX6 watchdog is not able to reset
> the phyFLEX SoM properly. Thus disable the internal i.MX6 watchdog to
> prevent unexpected PMIC settings after reset.
> 
> NOTE: This patch should not be backported as it might break existing
> uses and fixes in bootloaders.
> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
index 80adb2a02cc9..65fd7b4a6f27 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
@@ -464,3 +464,11 @@  &usdhc3 {
 	vmmc-supply = <&vdd_sd0_reg>;
 	status = "disabled";
 };
+
+&wdog1 {
+	/*
+	 * Rely on PMIC reboot handler. Internal i.MX6 watchdog, that is also
+	 * used for reboot, does not reset all external PMIC voltages on reset.
+	 */
+	status = "disabled";
+};