| Message ID | 20230915021509.25773-3-quic_tengfan@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: qcom: Add uart console support for SM4450 | expand |
On 15/09/2023 04:15, Tengfei Fan wrote: > Add the SoC specific compatible for SM4450 implementing arm,mmu-500. > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > index cf29ab10501c..b57751c8ad90 100644 > --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > @@ -47,6 +47,7 @@ properties: > - qcom,sdx55-smmu-500 > - qcom,sdx65-smmu-500 > - qcom,sdx75-smmu-500 > + - qcom,sm4450-smmu-500 > - qcom,sm6115-smmu-500 > - qcom,sm6125-smmu-500 > - qcom,sm6350-smmu-500 > @@ -70,6 +71,7 @@ properties: > - qcom,sc8180x-smmu-500 > - qcom,sc8280xp-smmu-500 > - qcom,sdm845-smmu-500 > + - qcom,sm4450-smmu-500 Isn't there comment just few lines above your edit? Comment saying DON'T? Best regards, Krzysztof
在 9/15/2023 3:11 PM, Krzysztof Kozlowski 写道: > On 15/09/2023 04:15, Tengfei Fan wrote: >> Add the SoC specific compatible for SM4450 implementing arm,mmu-500. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index cf29ab10501c..b57751c8ad90 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -47,6 +47,7 @@ properties: >> - qcom,sdx55-smmu-500 >> - qcom,sdx65-smmu-500 >> - qcom,sdx75-smmu-500 >> + - qcom,sm4450-smmu-500 >> - qcom,sm6115-smmu-500 >> - qcom,sm6125-smmu-500 >> - qcom,sm6350-smmu-500 >> @@ -70,6 +71,7 @@ properties: >> - qcom,sc8180x-smmu-500 >> - qcom,sc8280xp-smmu-500 >> - qcom,sdm845-smmu-500 >> + - qcom,sm4450-smmu-500 > > Isn't there comment just few lines above your edit? Comment saying DON'T? yes, I saw this "DON'T" comment, but if I remove "qcom,sm4450-smmu-500" from sm4450.dtsi and this arm,smmu.yaml, will get DT check warning about this, this warning cannot be find after add "qcom,sm4450-smmu-500" from sm4450.dtsi and this arm,smmu.yaml, so update this patch again. > > > Best regards, > Krzysztof >
在 9/15/2023 3:11 PM, Krzysztof Kozlowski 写道: > On 15/09/2023 04:15, Tengfei Fan wrote: >> Add the SoC specific compatible for SM4450 implementing arm,mmu-500. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index cf29ab10501c..b57751c8ad90 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -47,6 +47,7 @@ properties: >> - qcom,sdx55-smmu-500 >> - qcom,sdx65-smmu-500 >> - qcom,sdx75-smmu-500 >> + - qcom,sm4450-smmu-500 >> - qcom,sm6115-smmu-500 >> - qcom,sm6125-smmu-500 >> - qcom,sm6350-smmu-500 >> @@ -70,6 +71,7 @@ properties: >> - qcom,sc8180x-smmu-500 >> - qcom,sc8280xp-smmu-500 >> - qcom,sdm845-smmu-500 >> + - qcom,sm4450-smmu-500 > > Isn't there comment just few lines above your edit? Comment saying DON'T? > > > Best regards, > Krzysztof > Hi Kraysztof I seems haven't understand your comments totaly. I want to confirm that if you think only need "qcom,smmu-500" and "arm,mmu-500" compitbale name, needn't specific compitable name for each platform?
On 15/09/2023 10:52, Tengfei Fan wrote: > > > 在 9/15/2023 3:11 PM, Krzysztof Kozlowski 写道: >> On 15/09/2023 04:15, Tengfei Fan wrote: >>> Add the SoC specific compatible for SM4450 implementing arm,mmu-500. >>> >>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>> index cf29ab10501c..b57751c8ad90 100644 >>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>> @@ -47,6 +47,7 @@ properties: >>> - qcom,sdx55-smmu-500 >>> - qcom,sdx65-smmu-500 >>> - qcom,sdx75-smmu-500 >>> + - qcom,sm4450-smmu-500 >>> - qcom,sm6115-smmu-500 >>> - qcom,sm6125-smmu-500 >>> - qcom,sm6350-smmu-500 >>> @@ -70,6 +71,7 @@ properties: >>> - qcom,sc8180x-smmu-500 >>> - qcom,sc8280xp-smmu-500 >>> - qcom,sdm845-smmu-500 >>> + - qcom,sm4450-smmu-500 >> >> Isn't there comment just few lines above your edit? Comment saying DON'T? >> >> >> Best regards, >> Krzysztof >> > Hi Kraysztof > I seems haven't understand your comments totaly. > I want to confirm that if you think only need "qcom,smmu-500" and > "arm,mmu-500" compitbale name, needn't specific compitable name for each > platform? No, please read the comment. It tells you explicitly what to do - which compatible add where. Best regards, Krzysztof
On 15/09/2023 09:15, Tengfei Fan wrote: > > > 在 9/15/2023 3:11 PM, Krzysztof Kozlowski 写道: >> On 15/09/2023 04:15, Tengfei Fan wrote: >>> Add the SoC specific compatible for SM4450 implementing arm,mmu-500. >>> >>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>> index cf29ab10501c..b57751c8ad90 100644 >>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>> @@ -47,6 +47,7 @@ properties: >>> - qcom,sdx55-smmu-500 >>> - qcom,sdx65-smmu-500 >>> - qcom,sdx75-smmu-500 >>> + - qcom,sm4450-smmu-500 >>> - qcom,sm6115-smmu-500 >>> - qcom,sm6125-smmu-500 >>> - qcom,sm6350-smmu-500 >>> @@ -70,6 +71,7 @@ properties: >>> - qcom,sc8180x-smmu-500 >>> - qcom,sc8280xp-smmu-500 >>> - qcom,sdm845-smmu-500 >>> + - qcom,sm4450-smmu-500 >> >> Isn't there comment just few lines above your edit? Comment saying DON'T? > yes, I saw this "DON'T" comment, but if I remove "qcom,sm4450-smmu-500" > from sm4450.dtsi and this arm,smmu.yaml, will get DT check warning about Why would you remove it? > this, this warning cannot be find after add "qcom,sm4450-smmu-500" from > sm4450.dtsi and this arm,smmu.yaml, so update this patch again. What does the comment say? Why are you adding it to the enum which asks - do not add to this enum, but add to other above and below? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml index cf29ab10501c..b57751c8ad90 100644 --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml @@ -47,6 +47,7 @@ properties: - qcom,sdx55-smmu-500 - qcom,sdx65-smmu-500 - qcom,sdx75-smmu-500 + - qcom,sm4450-smmu-500 - qcom,sm6115-smmu-500 - qcom,sm6125-smmu-500 - qcom,sm6350-smmu-500 @@ -70,6 +71,7 @@ properties: - qcom,sc8180x-smmu-500 - qcom,sc8280xp-smmu-500 - qcom,sdm845-smmu-500 + - qcom,sm4450-smmu-500 - qcom,sm6115-smmu-500 - qcom,sm6350-smmu-500 - qcom,sm6375-smmu-500 @@ -468,6 +470,7 @@ allOf: - qcom,sdm845-smmu-500 - qcom,sdx55-smmu-500 - qcom,sdx65-smmu-500 + - qcom,sm4450-smmu-500 - qcom,sm6350-smmu-500 - qcom,sm6375-smmu-500 - qcom,sm8350-smmu-500
Add the SoC specific compatible for SM4450 implementing arm,mmu-500. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ 1 file changed, 3 insertions(+)