| Message ID | 20240317184130.157695-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] arm64: dts: allwinner: Pine H64: correctly remove reg_gmac_3v3 | expand |
On Sun, 17 Mar 2024 19:41:27 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: Hi Krzysztof, > There is no "reg_gmac_3v3" device node in sun50i-h6-pine-h64.dts, > although there is "gmac-3v3" with "reg_gmac_3v3" label, so let's assume > author wanted to remove that node. Delete node via phandle, not via > full node path, to fix this. Ah, that's a good catch! Indeed that regulator node is still in the DTB right now. > Fixes: f33a91175029 ("arm64: dts: allwinner: add pineh64 model B") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Successfully compiled the DTB and can confirm that the node is gone now. Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts > index b710f1a0f53a..1b6e5595ac6e 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts > @@ -5,12 +5,12 @@ > > #include "sun50i-h6-pine-h64.dts" > > +/delete-node/ ®_gmac_3v3; > + > / { > model = "Pine H64 model B"; > compatible = "pine64,pine-h64-model-b", "allwinner,sun50i-h6"; > > - /delete-node/ reg_gmac_3v3; > - > wifi_pwrseq: wifi_pwrseq { > compatible = "mmc-pwrseq-simple"; > reset-gpios = <&r_pio 1 3 GPIO_ACTIVE_LOW>; /* PM3 */
Dne nedelja, 17. marec 2024 ob 19:41:27 CET je Krzysztof Kozlowski napisal(a): > There is no "reg_gmac_3v3" device node in sun50i-h6-pine-h64.dts, > although there is "gmac-3v3" with "reg_gmac_3v3" label, so let's assume > author wanted to remove that node. Delete node via phandle, not via > full node path, to fix this. > > Fixes: f33a91175029 ("arm64: dts: allwinner: add pineh64 model B") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > --- > arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts > index b710f1a0f53a..1b6e5595ac6e 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts > @@ -5,12 +5,12 @@ > > #include "sun50i-h6-pine-h64.dts" > > +/delete-node/ ®_gmac_3v3; > + > / { > model = "Pine H64 model B"; > compatible = "pine64,pine-h64-model-b", "allwinner,sun50i-h6"; > > - /delete-node/ reg_gmac_3v3; > - > wifi_pwrseq: wifi_pwrseq { > compatible = "mmc-pwrseq-simple"; > reset-gpios = <&r_pio 1 3 GPIO_ACTIVE_LOW>; /* PM3 */ >
Dne nedelja, 17. marec 2024 ob 19:41:27 GMT +2 je Krzysztof Kozlowski napisal(a): > There is no "reg_gmac_3v3" device node in sun50i-h6-pine-h64.dts, > although there is "gmac-3v3" with "reg_gmac_3v3" label, so let's assume > author wanted to remove that node. Delete node via phandle, not via > full node path, to fix this. > > Fixes: f33a91175029 ("arm64: dts: allwinner: add pineh64 model B") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Applied all, thanks! Best regards, Jernej > --- > arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts > index b710f1a0f53a..1b6e5595ac6e 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts > @@ -5,12 +5,12 @@ > > #include "sun50i-h6-pine-h64.dts" > > +/delete-node/ ®_gmac_3v3; > + > / { > model = "Pine H64 model B"; > compatible = "pine64,pine-h64-model-b", "allwinner,sun50i-h6"; > > - /delete-node/ reg_gmac_3v3; > - > wifi_pwrseq: wifi_pwrseq { > compatible = "mmc-pwrseq-simple"; > reset-gpios = <&r_pio 1 3 GPIO_ACTIVE_LOW>; /* PM3 */ >
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts index b710f1a0f53a..1b6e5595ac6e 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts @@ -5,12 +5,12 @@ #include "sun50i-h6-pine-h64.dts" +/delete-node/ ®_gmac_3v3; + / { model = "Pine H64 model B"; compatible = "pine64,pine-h64-model-b", "allwinner,sun50i-h6"; - /delete-node/ reg_gmac_3v3; - wifi_pwrseq: wifi_pwrseq { compatible = "mmc-pwrseq-simple"; reset-gpios = <&r_pio 1 3 GPIO_ACTIVE_LOW>; /* PM3 */
There is no "reg_gmac_3v3" device node in sun50i-h6-pine-h64.dts, although there is "gmac-3v3" with "reg_gmac_3v3" label, so let's assume author wanted to remove that node. Delete node via phandle, not via full node path, to fix this. Fixes: f33a91175029 ("arm64: dts: allwinner: add pineh64 model B") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)