| Message ID | 20240317184130.157695-3-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] arm64: dts: allwinner: Pine H64: correctly remove reg_gmac_3v3 | expand |
On 17/03/2024 19:41, Krzysztof Kozlowski wrote: > Delete node via phandle, not via full node path, to avoid easy mistakes > - if original node name changes, such deletion would be ineffective and > not reported by the dtc as error. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm/boot/dts/allwinner/sun8i-h2-plus-orangepi-r1.dts | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Eh, copy-paste, the subject prefix should be "ARM:". Best regards, Krzysztof
Dne nedelja, 17. marec 2024 ob 19:42:51 CET je Krzysztof Kozlowski napisal(a): > On 17/03/2024 19:41, Krzysztof Kozlowski wrote: > > Delete node via phandle, not via full node path, to avoid easy mistakes > > - if original node name changes, such deletion would be ineffective and > > not reported by the dtc as error. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > arch/arm/boot/dts/allwinner/sun8i-h2-plus-orangepi-r1.dts | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > Eh, copy-paste, the subject prefix should be "ARM:". Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> I can fix it when applying. Best regards, Jernej > > Best regards, > Krzysztof > >
diff --git a/arch/arm/boot/dts/allwinner/sun8i-h2-plus-orangepi-r1.dts b/arch/arm/boot/dts/allwinner/sun8i-h2-plus-orangepi-r1.dts index 3356f4210d45..067a2ecbc0a4 100644 --- a/arch/arm/boot/dts/allwinner/sun8i-h2-plus-orangepi-r1.dts +++ b/arch/arm/boot/dts/allwinner/sun8i-h2-plus-orangepi-r1.dts @@ -43,11 +43,12 @@ /* Orange Pi R1 is based on Orange Pi Zero design */ #include "sun8i-h2-plus-orangepi-zero.dts" +/delete-node/ ®_vcc_wifi; + / { model = "Xunlong Orange Pi R1"; compatible = "xunlong,orangepi-r1", "allwinner,sun8i-h2-plus"; - /delete-node/ reg_vcc_wifi; /* * Ths pin of this regulator is the same with the Wi-Fi extra
Delete node via phandle, not via full node path, to avoid easy mistakes - if original node name changes, such deletion would be ineffective and not reported by the dtc as error. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm/boot/dts/allwinner/sun8i-h2-plus-orangepi-r1.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)