diff mbox series

[v5,2/2] irqchip/gic-v3-its: remove BUG_ON in its_vpe_irq_domain_alloc

Message ID 20240418061053.96803-3-guanrui.huang@linux.alibaba.com (mailing list archive)
State New
Headers show
Series irqchip/gic-v3-its: Fix double free on error | expand

Commit Message

Guanrui Huang April 18, 2024, 6:10 a.m. UTC 
This BUG_ON() is useless, because the same effect will be obtained 
by letting the code run its course and vm being dereferenced,
triggering an exception.

So just remove this check.

Acked-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Guanrui Huang <guanrui.huang@linux.alibaba.com>
---
 drivers/irqchip/irq-gic-v3-its.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Zenghui Yu April 18, 2024, 6:56 a.m. UTC | #1 
On 2024/4/18 14:10, Guanrui Huang wrote:
> This BUG_ON() is useless, because the same effect will be obtained
> by letting the code run its course and vm being dereferenced,
> triggering an exception.
> 
> So just remove this check.
> 
> Acked-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Guanrui Huang <guanrui.huang@linux.alibaba.com>

Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
diff mbox series

Patch

diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index 2305f6b524a9..55c83e19719d 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -4521,8 +4521,6 @@  static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virq
 	struct page *vprop_page;
 	int base, nr_ids, i, err = 0;
 
-	BUG_ON(!vm);
-
 	bitmap = its_lpi_alloc(roundup_pow_of_two(nr_irqs), &base, &nr_ids);
 	if (!bitmap)
 		return -ENOMEM;