| Message ID | 20240518211159.142920-3-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] dt-bindings: mfd: mediatek,mt8195-scpsys: add mediatek,mt8365-scpsys | expand |
Il 18/05/24 23:11, Krzysztof Kozlowski ha scritto: > The top SCPSYS node is not a power domain provider. It's child > "power-controller" is instead. Fix dtbs_check warnings like: > > mt8365-evk.dtb: syscon@10006000: '#power-domain-cells' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Well if you're fixing that by migrating to scpsys compatible, you might as well resolve all of the warnings in one commit, removing that power-domain-cells property in patch [2/4], otherwise this one is technically a fix for that. Please squash [2/4] and [3/4], like that it just makes more sense. Cheers, Angelo > --- > arch/arm64/boot/dts/mediatek/mt8365.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > index d3da5a22c2d2..eb449bfa8803 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > @@ -302,7 +302,6 @@ syscfg_pctl: syscfg-pctl@10005000 { > scpsys: syscon@10006000 { > compatible = "mediatek,mt8365-scpsys", "syscon", "simple-mfd"; > reg = <0 0x10006000 0 0x1000>; > - #power-domain-cells = <1>; > > /* System Power Manager */ > spm: power-controller {
On 20/05/2024 11:58, AngeloGioacchino Del Regno wrote: > Il 18/05/24 23:11, Krzysztof Kozlowski ha scritto: >> The top SCPSYS node is not a power domain provider. It's child >> "power-controller" is instead. Fix dtbs_check warnings like: >> >> mt8365-evk.dtb: syscon@10006000: '#power-domain-cells' does not match any of the regexes: 'pinctrl-[0-9]+' >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Well if you're fixing that by migrating to scpsys compatible, you might as well > resolve all of the warnings in one commit, removing that power-domain-cells > property in patch [2/4], otherwise this one is technically a fix for that. > > Please squash [2/4] and [3/4], like that it just makes more sense. > That's independent thing. Previous compatible - syscfg - also did not allow power domains. The difference is that bindings did not print a warning without my change. We can reverse the patches if this is more suitable. Best regards, Krzysztof
Il 20/05/24 12:03, Krzysztof Kozlowski ha scritto: > On 20/05/2024 11:58, AngeloGioacchino Del Regno wrote: >> Il 18/05/24 23:11, Krzysztof Kozlowski ha scritto: >>> The top SCPSYS node is not a power domain provider. It's child >>> "power-controller" is instead. Fix dtbs_check warnings like: >>> >>> mt8365-evk.dtb: syscon@10006000: '#power-domain-cells' does not match any of the regexes: 'pinctrl-[0-9]+' >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> Well if you're fixing that by migrating to scpsys compatible, you might as well >> resolve all of the warnings in one commit, removing that power-domain-cells >> property in patch [2/4], otherwise this one is technically a fix for that. >> >> Please squash [2/4] and [3/4], like that it just makes more sense. >> > > That's independent thing. Previous compatible - syscfg - also did not > allow power domains. The difference is that bindings did not print a > warning without my change. We can reverse the patches if this is more > suitable. > You're still introducing a warning with patch 2. As for swapping the order, that could also be a solution, but I still don't see that as an independent thing - in any case, swapping them is something I can do while applying, eventually.
diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi index d3da5a22c2d2..eb449bfa8803 100644 --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi @@ -302,7 +302,6 @@ syscfg_pctl: syscfg-pctl@10005000 { scpsys: syscon@10006000 { compatible = "mediatek,mt8365-scpsys", "syscon", "simple-mfd"; reg = <0 0x10006000 0 0x1000>; - #power-domain-cells = <1>; /* System Power Manager */ spm: power-controller {
The top SCPSYS node is not a power domain provider. It's child "power-controller" is instead. Fix dtbs_check warnings like: mt8365-evk.dtb: syscon@10006000: '#power-domain-cells' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/mediatek/mt8365.dtsi | 1 - 1 file changed, 1 deletion(-)