| Message ID | 20240518211159.142920-4-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] dt-bindings: mfd: mediatek,mt8195-scpsys: add mediatek,mt8365-scpsys | expand |
Il 18/05/24 23:11, Krzysztof Kozlowski ha scritto: > The MT6297 PMIC has address/size cells == 1, thus its syscon child node > has incorrect number of entries in "reg" property. Fix dtbs_check > warning: > > mt8173-elm.dtb: syscon@c000: reg: [[0, 49152], [0, 264]] is too long > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> That node is unused and not needed at all, even... Unless anyone has any strong opinion against, I suggest to simply remove it. Cheers, Angelo > --- > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > index 6d962d437e02..0e2439860223 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > @@ -1138,7 +1138,7 @@ rtc: mt6397rtc { > syscfg_pctl_pmic: syscon@c000 { > compatible = "mediatek,mt6397-pctl-pmic-syscfg", > "syscon"; > - reg = <0 0x0000c000 0 0x0108>; > + reg = <0x0000c000 0x0108>; > }; > }; > };
On 20/05/2024 12:07, AngeloGioacchino Del Regno wrote: > Il 18/05/24 23:11, Krzysztof Kozlowski ha scritto: >> The MT6297 PMIC has address/size cells == 1, thus its syscon child node >> has incorrect number of entries in "reg" property. Fix dtbs_check >> warning: >> >> mt8173-elm.dtb: syscon@c000: reg: [[0, 49152], [0, 264]] is too long >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > That node is unused and not needed at all, even... > Unless anyone has any strong opinion against, I suggest to simply remove it. Sure, works for me. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi index 6d962d437e02..0e2439860223 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi @@ -1138,7 +1138,7 @@ rtc: mt6397rtc { syscfg_pctl_pmic: syscon@c000 { compatible = "mediatek,mt6397-pctl-pmic-syscfg", "syscon"; - reg = <0 0x0000c000 0 0x0108>; + reg = <0x0000c000 0x0108>; }; }; };
The MT6297 PMIC has address/size cells == 1, thus its syscon child node has incorrect number of entries in "reg" property. Fix dtbs_check warning: mt8173-elm.dtb: syscon@c000: reg: [[0, 49152], [0, 264]] is too long Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)