Frees gate after if statement in clk-sunxi.c

Commit Message

Nick June 16, 2014, 3:21 a.m. UTC

New Patch Just Fixed Typo for my email client.
Signed-off-by: Nick <[e-mail]>
---
 drivers/clk/sunxi/clk-sunxi.c | 1 +
 1 file changed, 1 insertion(+)

        /* allocate fixed-rate and gate clock structs */
Cheers Nick

On Sun, Jun 15, 2014 at 4:30 PM, Maxime Ripard
<[e-mail]> wrote:
> On Sat, Jun 14, 2014 at 02:11:48PM -0400, Nick wrote:
>> Signed-off-by: Nick <[e-mail]>
>
> This should be your full real name here.
>
>> ---
>>  drivers/clk/sunxi/clk-sunxi.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
>> index 4264834..6f4fc51 100644
>> --- a/drivers/clk/sunxi/clk-sunxi.c
>> +++ b/drivers/clk/sunxi/clk-sunxi.c
>> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
>>       u32 rate;
>>
>>       if (of_property_read_u32(node, "clock-frequency", &rate))
>> +             kree(gate);
>
> There's a typo in kfree. How does that even compile?
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

Comments

Nick June 16, 2014, 3:31 a.m. UTC | #1

Seems the bug is fixed , don't worry about resent patch.
Thanks Nick

On Sun, Jun 15, 2014 at 11:21 PM, Nick Krause <[e-mail]> wrote:
> New Patch Just Fixed Typo for my email client.
> Signed-off-by: Nick <[e-mail]>
> ---
>  drivers/clk/sunxi/clk-sunxi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.
> c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
> device_node *node)
>         u32 rate;
>
>         if (of_property_read_u32(node, "clock-frequency", &rate))
> +               kfree(gate);
>                 return;
>
>         /* allocate fixed-rate and gate clock structs */
> Cheers Nick
>
> On Sun, Jun 15, 2014 at 4:30 PM, Maxime Ripard
> <[e-mail]> wrote:
>> On Sat, Jun 14, 2014 at 02:11:48PM -0400, Nick wrote:
>>> Signed-off-by: Nick <[e-mail]>
>>
>> This should be your full real name here.
>>
>>> ---
>>>  drivers/clk/sunxi/clk-sunxi.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
>>> index 4264834..6f4fc51 100644
>>> --- a/drivers/clk/sunxi/clk-sunxi.c
>>> +++ b/drivers/clk/sunxi/clk-sunxi.c
>>> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
>>>       u32 rate;
>>>
>>>       if (of_property_read_u32(node, "clock-frequency", &rate))
>>> +             kree(gate);
>>
>> There's a typo in kfree. How does that even compile?
>>
>> --
>> Maxime Ripard, Free Electrons
>> Embedded Linux, Kernel and Android engineering
>> http://free-electrons.com

Russell King - ARM Linux June 16, 2014, 8:15 a.m. UTC | #2

On Sun, Jun 15, 2014 at 11:31:41PM -0400, Nick Krause wrote:
> Seems the bug is fixed , don't worry about resent patch.
> Thanks Nick
> 
> On Sun, Jun 15, 2014 at 11:21 PM, Nick Krause <[e-mail]> wrote:
> > @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
> > device_node *node)
> >         u32 rate;
> >
> >         if (of_property_read_u32(node, "clock-frequency", &rate))
> > +               kfree(gate);
> >                 return;

In any case, the kernel is not coded in Python.

C uses braces { } to enclose blocks of code, and does not care about
indentation - indentation is meaningless to C.  Python purely identifies
blocks of code by indentation alone.

Please take account of the programming language when creating patches.

Patch

diff --git a/drivers/clk/sunxi/clk-sunxi.
c b/drivers/clk/sunxi/clk-sunxi.c
index 4264834..6f4fc51 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -42,6 +42,7 @@  static void __init sun4i_osc_clk_setup(struct
device_node *node)
        u32 rate;

        if (of_property_read_u32(node, "clock-frequency", &rate))
+               kfree(gate);
                return;