mbox series

[RFC,v6,0/8] Add support for ipq8064 tsens

Message ID 20200814134123.14566-1-ansuelsmth@gmail.com (mailing list archive)
Headers show
Series Add support for ipq8064 tsens | expand

Message

Christian Marangi Aug. 14, 2020, 1:41 p.m. UTC
This patchset convert msm8960 to reg_filed, use int_common instead 
of a custom function and fix wrong tsens get_temp function for msm8960.
Ipq8064 SoCs tsens driver is based on 8960 tsens driver. Ipq8064 needs
to be registered as a gcc child as the tsens regs on this platform are
shared with the controller.
This is based on work and code here
https://git.linaro.org/people/amit.kucheria/kernel.git/log/?h=wrk3/tsens-8960-breakage

v6:
* Fix spelling error (can't find the problem with variable misallignment)
* Rework big if-else
* Remove extra comments
* Add description about different interrupts
v5:
* Conver driver to use reg_fiedl
* Use init_common 
* Drop custom set_trip and set_interrupt
* Use common set_trip and set_interrupt
* Fix bad get_temp function
* Add missing hardcoded slope
v4:
* Fix compilation error and warning reported by the bot
v3:
* Change driver to register as child instead of use phandle
v2:
* Fix dt-bindings problems

Ansuel Smith (8):
  drivers: thermal: tsens: use get_temp for tsens_valid
  drivers: thermal: tsens: Add VER_0 tsens version
  drivers: thermal: tsens: Convert msm8960 to reg_field
  drivers: thermal: tsens: Use init_common for msm8960
  drivers: thermal: tsens: Fix wrong get_temp for msm8960
  drivers: thermal: tsens: Change calib_backup name for msm8960
  drivers: thermal: tsens: Add support for ipq8064-tsens
  dt-bindings: thermal: tsens: Document ipq8064 bindings

 .../bindings/thermal/qcom-tsens.yaml          |  50 ++++-
 drivers/thermal/qcom/tsens-8960.c             | 172 +++++++++++-------
 drivers/thermal/qcom/tsens.c                  | 130 +++++++++++--
 drivers/thermal/qcom/tsens.h                  |   7 +-
 4 files changed, 270 insertions(+), 89 deletions(-)

Comments

Amit Kucheria Sept. 28, 2020, 11:32 a.m. UTC | #1
Hi Ansuel,

Just a quick note to say that I'm not ignoring this, just on
vacations. I'll be back to review this in a few days.

Regards,
Amit

On Fri, Aug 14, 2020 at 7:12 PM Ansuel Smith <ansuelsmth@gmail.com> wrote:
>
> This patchset convert msm8960 to reg_filed, use int_common instead
> of a custom function and fix wrong tsens get_temp function for msm8960.
> Ipq8064 SoCs tsens driver is based on 8960 tsens driver. Ipq8064 needs
> to be registered as a gcc child as the tsens regs on this platform are
> shared with the controller.
> This is based on work and code here
> https://git.linaro.org/people/amit.kucheria/kernel.git/log/?h=wrk3/tsens-8960-breakage
>
> v6:
> * Fix spelling error (can't find the problem with variable misallignment)
> * Rework big if-else
> * Remove extra comments
> * Add description about different interrupts
> v5:
> * Conver driver to use reg_fiedl
> * Use init_common
> * Drop custom set_trip and set_interrupt
> * Use common set_trip and set_interrupt
> * Fix bad get_temp function
> * Add missing hardcoded slope
> v4:
> * Fix compilation error and warning reported by the bot
> v3:
> * Change driver to register as child instead of use phandle
> v2:
> * Fix dt-bindings problems
>
> Ansuel Smith (8):
>   drivers: thermal: tsens: use get_temp for tsens_valid
>   drivers: thermal: tsens: Add VER_0 tsens version
>   drivers: thermal: tsens: Convert msm8960 to reg_field
>   drivers: thermal: tsens: Use init_common for msm8960
>   drivers: thermal: tsens: Fix wrong get_temp for msm8960
>   drivers: thermal: tsens: Change calib_backup name for msm8960
>   drivers: thermal: tsens: Add support for ipq8064-tsens
>   dt-bindings: thermal: tsens: Document ipq8064 bindings
>
>  .../bindings/thermal/qcom-tsens.yaml          |  50 ++++-
>  drivers/thermal/qcom/tsens-8960.c             | 172 +++++++++++-------
>  drivers/thermal/qcom/tsens.c                  | 130 +++++++++++--
>  drivers/thermal/qcom/tsens.h                  |   7 +-
>  4 files changed, 270 insertions(+), 89 deletions(-)
>
> --
> 2.27.0
>
Christian Marangi Sept. 28, 2020, 11:35 a.m. UTC | #2
> -----Original Message-----
> From: Amit Kucheria <amitk@kernel.org>
> Sent: Monday, September 28, 2020 1:33 PM
> To: Ansuel Smith <ansuelsmth@gmail.com>
> Cc: Andy Gross <agross@kernel.org>; Bjorn Andersson
> <bjorn.andersson@linaro.org>; Zhang Rui <rui.zhang@intel.com>; Daniel
> Lezcano <daniel.lezcano@linaro.org>; Rob Herring <robh+dt@kernel.org>;
> linux-arm-msm <linux-arm-msm@vger.kernel.org>; Linux PM list <linux-
> pm@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE
> TREE BINDINGS <devicetree@vger.kernel.org>; LKML <linux-
> kernel@vger.kernel.org>
> Subject: Re: [RFC PATCH v6 0/8] Add support for ipq8064 tsens
> 
> Hi Ansuel,
> 
> Just a quick note to say that I'm not ignoring this, just on
> vacations. I'll be back to review this in a few days.
> 
> Regards,
> Amit
> 

Thx a lot. Was thinking of resending this but I will wait.