| Message ID | 20230328-topic-msgram_mpm-v7-0-6ee2bfeaac2c@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Resolve MPM register space situation | expand |
Konrad! On Mon, Nov 27 2023 at 16:52, Konrad Dybcio wrote: This list of version changes is useful, but seriously not on top of the cover letter. It makes me scroll down 60 lines to find the real meat. <SNIP> > Depends on resolution of https://github.com/devicetree-org/dt-schema/issues/104 Is this resolved? I can't figure out from this non-format whether this belongs to V1 or to the actual cover letter... > The MPM (and some other things, irrelevant to this patchset) resides > (as far as the ARM cores are concerned, anyway) in a MMIO-mapped region > that's a portion of the RPM (low-power management core)'s RAM, known > as the RPM Message RAM. Representing this relation in the Device Tree > creates some challenges, as one would either have to treat a memory > region as a bus, map nodes in a way such that their reg-s would be > overlapping, or supply the nodes with a slice of that region. > > This series implements the third option, by adding a qcom,rpm-msg-ram > property, which has been used for some drivers poking into this region > before. Bindings ABI compatibility is preserved through keeping the > "normal" (a.k.a read the reg property and map that region) way of > passing the register space. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Signed-off-by on the cover letter is completely meaningless. Thanks, tglx
On 8.12.2023 15:33, Thomas Gleixner wrote: > Konrad! > > On Mon, Nov 27 2023 at 16:52, Konrad Dybcio wrote: > > This list of version changes is useful, but seriously not on top of the > cover letter. It makes me scroll down 60 lines to find the real meat. Ack > > <SNIP> > >> Depends on resolution of https://github.com/devicetree-org/dt-schema/issues/104 > > Is this resolved? I can't figure out from this non-format whether this > belongs to V1 or to the actual cover letter... Yes it has been resolved since > >> The MPM (and some other things, irrelevant to this patchset) resides >> (as far as the ARM cores are concerned, anyway) in a MMIO-mapped region >> that's a portion of the RPM (low-power management core)'s RAM, known >> as the RPM Message RAM. Representing this relation in the Device Tree >> creates some challenges, as one would either have to treat a memory >> region as a bus, map nodes in a way such that their reg-s would be >> overlapping, or supply the nodes with a slice of that region. >> >> This series implements the third option, by adding a qcom,rpm-msg-ram >> property, which has been used for some drivers poking into this region >> before. Bindings ABI compatibility is preserved through keeping the >> "normal" (a.k.a read the reg property and map that region) way of >> passing the register space. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Signed-off-by on the cover letter is completely meaningless. Yes, I realize that. Blame b4. Konrad
December 9, 2023 at 9:00 AM, "Konrad Dybcio" <konrad.dybcio@linaro.org> wrote: > > Signed-off-by on the cover letter is completely meaningless. > > Yes, I realize that. Blame b4. It's not -- some subsystems use cover letters as merge commits. -K
v6 -> v7: - Actually check the rvalue of of_address_to_resource - Pick up rb - Link to v6: https://lore.kernel.org/r/20230328-topic-msgram_mpm-v6-0-682e4855b7e2@linaro.org v5 -> v6: - Resending due to no responses. - Change of base to next-20231124 (no changes to the patch) Link to v5: https://lore.kernel.org/r/20230328-topic-msgram_mpm-v5-0-6e06278896b5@linaro.org v4 -> v5: - Pick up tags - Rebase on Rob's of_ header untanglement Link to v4: https://lore.kernel.org/r/20230328-topic-msgram_mpm-v4-0-bae382dc0f92@linaro.org v3 -> v4: - Fix up indentation in the bindings patch - Add an example glink-edge subnode to remoteproc-rpm (its bindings require that..) Link to v3: https://lore.kernel.org/r/20230328-topic-msgram_mpm-v3-0-2c72f27b4706@linaro.org v2 -> v3: - Fix the example - Pick up tags - remove the outdated example from the cover letter, check bindings should you want to see one The bindings for the wrapper node used in the yaml example are merged in qcom/for-next Link to v2: https://lore.kernel.org/r/20230328-topic-msgram_mpm-v2-0-e24a48e57f0d@linaro.org v1 -> v2: - deprecate 'reg', make qcom,rpm-msg-ram required [1/2] - Use devm_ioremap() [2/2] Link to v1: https://lore.kernel.org/r/20230328-topic-msgram_mpm-v1-0-1b788a5f5a33@linaro.org Depends on resolution of https://github.com/devicetree-org/dt-schema/issues/104 The MPM (and some other things, irrelevant to this patchset) resides (as far as the ARM cores are concerned, anyway) in a MMIO-mapped region that's a portion of the RPM (low-power management core)'s RAM, known as the RPM Message RAM. Representing this relation in the Device Tree creates some challenges, as one would either have to treat a memory region as a bus, map nodes in a way such that their reg-s would be overlapping, or supply the nodes with a slice of that region. This series implements the third option, by adding a qcom,rpm-msg-ram property, which has been used for some drivers poking into this region before. Bindings ABI compatibility is preserved through keeping the "normal" (a.k.a read the reg property and map that region) way of passing the register space. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Konrad Dybcio (2): dt-bindings: interrupt-controller: mpm: Pass MSG RAM slice through phandle irqchip: irq-qcom-mpm: Support passing a slice of SRAM as reg space .../bindings/interrupt-controller/qcom,mpm.yaml | 52 +++++++++++++++------- drivers/irqchip/irq-qcom-mpm.c | 26 +++++++++-- 2 files changed, 58 insertions(+), 20 deletions(-) --- base-commit: 48bbaf8b793e0770798519f8ee1ea2908ff0943a change-id: 20230328-topic-msgram_mpm-c688be3bc294 Best regards,