| Message ID | 1618398783-7834-6-git-send-email-skakit@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add PMIC DT files for sc7280 | expand |
On Wed, Apr 14, 2021 at 04:43:03PM +0530, satya priya wrote: > Subject: arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280 Please make sure to distinguish between the SoC (sc7280) and the board (sc7280-idp), this patch primarily adds stuff to the board not the SoC, this should be clear from the subject. > Include pm7325, pm8350c, pmk8350 and pmr735a DT files. How about something like 'The sc7280-idp has four PMICs, include their .dtsi files'? > Add channel nodes for pmk8350_vadc. It's not super important, but I don't like it when things like this get sneaked in with a commit message saying 'Include PMIC DT files for sc7280'. I would suggest a separate patch. And please mention that the channels are for the on die temperatures of the PMICs. > Also, add the thermal_zones node in dtsi. This is not the right patch to add it. This patch is about the sc7280-board and doesn't do anything (directly) with thermal zones. However other patches further down in the stack of in this series require the 'thermal-zones' to exist, hence the node should exist before these patches reference it. A dedicated patch adding the node seems like the best option to me.
On 2021-04-20 23:32, Matthias Kaehlcke wrote: > On Wed, Apr 14, 2021 at 04:43:03PM +0530, satya priya wrote: > >> Subject: arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280 > > Please make sure to distinguish between the SoC (sc7280) and the > board (sc7280-idp), this patch primarily adds stuff to the board not > the SoC, this should be clear from the subject. > Sure, will mention sc7280-idp in the subject. >> Include pm7325, pm8350c, pmk8350 and pmr735a DT files. > > How about something like 'The sc7280-idp has four PMICs, include their > .dtsi files'? > Okay. >> Add channel nodes for pmk8350_vadc. > > It's not super important, but I don't like it when things like this get > sneaked in with a commit message saying 'Include PMIC DT files for > sc7280'. I would suggest a separate patch. And please mention that > the channels are for the on die temperatures of the PMICs. > Okay, will make a separate patch for adding channel nodes. >> Also, add the thermal_zones node in dtsi. > > This is not the right patch to add it. This patch is about the > sc7280-board > and doesn't do anything (directly) with thermal zones. However other > patches further down in the stack of in this series require the > 'thermal-zones' to exist, hence the node should exist before these > patches > reference it. A dedicated patch adding the node seems like the best > option > to me. Okay, I will add a separate patch for adding thermal-zones node and place it in the beginning of the series. Thanks, Satya Priya
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts index 950ecb2..9293502 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts @@ -8,6 +8,10 @@ /dts-v1/; #include "sc7280.dtsi" +#include "pm7325.dtsi" +#include "pm8350c.dtsi" +#include "pmk8350.dtsi" +#include "pmr735a.dtsi" / { model = "Qualcomm Technologies, Inc. sc7280 IDP platform"; @@ -22,6 +26,32 @@ }; }; +&pmk8350_vadc { + pm8350_die_temp { + reg = <PM8350_ADC7_DIE_TEMP>; + label = "pm8350_die_temp"; + qcom,pre-scaling = <1 1>; + }; + + pmk8350_die_temp { + reg = <PMK8350_ADC7_DIE_TEMP>; + label = "pmk8350_die_temp"; + qcom,pre-scaling = <1 1>; + }; + + pmr735a_die_temp { + reg = <PMR735A_ADC7_DIE_TEMP>; + label = "pmr735a_die_temp"; + qcom,pre-scaling = <1 1>; + }; + + pmr735b_die_temp { + reg = <PMR735B_ADC7_DIE_TEMP>; + label = "pmr735b_die_temp"; + qcom,pre-scaling = <1 1>; + }; +}; + &qupv3_id_0 { status = "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 39cf0be..0f4fd33 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -605,4 +605,7 @@ <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; }; + + thermal_zones: thermal-zones { + }; };
Include pm7325, pm8350c, pmk8350 and pmr735a DT files. Add channel nodes for pmk8350_vadc. Also, add the thermal_zones node in dtsi. Signed-off-by: satya priya <skakit@codeaurora.org> --- arch/arm64/boot/dts/qcom/sc7280-idp.dts | 30 ++++++++++++++++++++++++++++++ arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ 2 files changed, 33 insertions(+)