| Message ID | 1670267670-15832-3-git-send-email-quic_khsieh@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add data-lanes and link-frequencies to dp_out endpoint | expand |
On Mon, 05 Dec 2022 11:14:27 -0800, Kuogee Hsieh wrote: > Add both data-lanes and link-frequencies property into endpoint > > Changes in v7: > -- split yaml out of dtsi patch > -- link-frequencies from link rate to symbol rate > -- deprecation of old data-lanes property > > Changes in v8: > -- correct Bjorn mail address to kernel.org > > Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> > --- > .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.yaml: properties:ports:properties:port@1:properties: 'properties' should not be valid under {'$ref': '#/definitions/json-schema-prop-names'} hint: A json-schema keyword was found instead of a DT property name. from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.yaml: properties:ports:properties:port@1:properties: 'additionalProperties' should not be valid under {'$ref': '#/definitions/json-schema-prop-names'} hint: A json-schema keyword was found instead of a DT property name. from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.yaml: properties:ports:properties:port@1:properties:properties: 'anyOf' conditional failed, one must be fixed: 'data-lanes' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] 'type' was expected from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.yaml: properties:ports:properties:port@1:properties:properties: 'anyOf' conditional failed, one must be fixed: 'link-frequencies' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] 'type' was expected from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.example.dtb: displayport-controller@ae90000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes', 'link-frequencies' were unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1670267670-15832-3-git-send-email-quic_khsieh@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 5 December 2022 22:14:27 GMT+03:00, Kuogee Hsieh <quic_khsieh@quicinc.com> wrote: >Add both data-lanes and link-frequencies property into endpoint > >Changes in v7: >-- split yaml out of dtsi patch >-- link-frequencies from link rate to symbol rate >-- deprecation of old data-lanes property > >Changes in v8: >-- correct Bjorn mail address to kernel.org > >Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> >--- > .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) > >diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >index f2515af..13d2c3c 100644 >--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >@@ -79,12 +79,6 @@ properties: > aux-bus: > $ref: /schemas/display/dp-aux-bus.yaml# > >- data-lanes: >- $ref: /schemas/types.yaml#/definitions/uint32-array >- minItems: 1 >- maxItems: 4 >- items: >- maximum: 3 These properties can still be used, e.g. Bjorn is submitting patches with the old property. I think this should be marked with deprecated: true instead of removal. > > "#sound-dai-cells": > const: 0 >@@ -105,6 +99,19 @@ properties: > $ref: /schemas/graph.yaml#/properties/port > description: Output endpoint of the controller > >+ properties: >+ endpoint: >+ $ref: /schemas/media/video-interfaces.yaml# >+ >+ properties: >+ data-lanes: >+ $ref: /schemas/types.yaml#/definitions/uint32-array >+ >+ link-frequencies: >+ $ref: /schemas/types.yaml#/definitions/uint64-array >+ >+ additionalProperties: false >+ > required: > - compatible > - reg >@@ -193,6 +200,9 @@ examples: > reg = <1>; > endpoint { > remote-endpoint = <&typec>; >+ data-lanes = <1 2>; >+ link-frequencies = /bits/ 64 <1620000000 2700000000 >+ 5400000000 8100000000>; > }; > }; > };
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index f2515af..13d2c3c 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -79,12 +79,6 @@ properties: aux-bus: $ref: /schemas/display/dp-aux-bus.yaml# - data-lanes: - $ref: /schemas/types.yaml#/definitions/uint32-array - minItems: 1 - maxItems: 4 - items: - maximum: 3 "#sound-dai-cells": const: 0 @@ -105,6 +99,19 @@ properties: $ref: /schemas/graph.yaml#/properties/port description: Output endpoint of the controller + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + + properties: + data-lanes: + $ref: /schemas/types.yaml#/definitions/uint32-array + + link-frequencies: + $ref: /schemas/types.yaml#/definitions/uint64-array + + additionalProperties: false + required: - compatible - reg @@ -193,6 +200,9 @@ examples: reg = <1>; endpoint { remote-endpoint = <&typec>; + data-lanes = <1 2>; + link-frequencies = /bits/ 64 <1620000000 2700000000 + 5400000000 8100000000>; }; }; };
Add both data-lanes and link-frequencies property into endpoint Changes in v7: -- split yaml out of dtsi patch -- link-frequencies from link rate to symbol rate -- deprecation of old data-lanes property Changes in v8: -- correct Bjorn mail address to kernel.org Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> --- .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-)