| Message ID | 20210521140031.1.Ibaca694aedfaff823feefa06b29ae746c641dd1a@changeid (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/2] nvmem: core: constify nvmem_cell_read_variable_common() return value | expand |
Quoting Douglas Anderson (2021-05-21 14:00:57) > The caller doesn't modify the memory pointed to by the pointer so it > can be const. > > Suggested-by: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
On 21/05/2021 22:00, Douglas Anderson wrote: > The caller doesn't modify the memory pointed to by the pointer so it > can be const. > > Suggested-by: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > Applied both thanks, --srini > drivers/nvmem/core.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index f9c9c9859919..4868aa876e1b 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -1609,9 +1609,9 @@ int nvmem_cell_read_u64(struct device *dev, const char *cell_id, u64 *val) > } > EXPORT_SYMBOL_GPL(nvmem_cell_read_u64); > > -static void *nvmem_cell_read_variable_common(struct device *dev, > - const char *cell_id, > - size_t max_len, size_t *len) > +static const void *nvmem_cell_read_variable_common(struct device *dev, > + const char *cell_id, > + size_t max_len, size_t *len) > { > struct nvmem_cell *cell; > int nbits; > @@ -1655,7 +1655,7 @@ int nvmem_cell_read_variable_le_u32(struct device *dev, const char *cell_id, > u32 *val) > { > size_t len; > - u8 *buf; > + const u8 *buf; > int i; > > buf = nvmem_cell_read_variable_common(dev, cell_id, sizeof(*val), &len); > @@ -1686,7 +1686,7 @@ int nvmem_cell_read_variable_le_u64(struct device *dev, const char *cell_id, > u64 *val) > { > size_t len; > - u8 *buf; > + const u8 *buf; > int i; > > buf = nvmem_cell_read_variable_common(dev, cell_id, sizeof(*val), &len); >
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index f9c9c9859919..4868aa876e1b 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -1609,9 +1609,9 @@ int nvmem_cell_read_u64(struct device *dev, const char *cell_id, u64 *val) } EXPORT_SYMBOL_GPL(nvmem_cell_read_u64); -static void *nvmem_cell_read_variable_common(struct device *dev, - const char *cell_id, - size_t max_len, size_t *len) +static const void *nvmem_cell_read_variable_common(struct device *dev, + const char *cell_id, + size_t max_len, size_t *len) { struct nvmem_cell *cell; int nbits; @@ -1655,7 +1655,7 @@ int nvmem_cell_read_variable_le_u32(struct device *dev, const char *cell_id, u32 *val) { size_t len; - u8 *buf; + const u8 *buf; int i; buf = nvmem_cell_read_variable_common(dev, cell_id, sizeof(*val), &len); @@ -1686,7 +1686,7 @@ int nvmem_cell_read_variable_le_u64(struct device *dev, const char *cell_id, u64 *val) { size_t len; - u8 *buf; + const u8 *buf; int i; buf = nvmem_cell_read_variable_common(dev, cell_id, sizeof(*val), &len);
The caller doesn't modify the memory pointed to by the pointer so it can be const. Suggested-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> --- drivers/nvmem/core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)