diff mbox series

[2/2] nvmem: qfprom: Improve the comment about regulator setting

Message ID 20210521140031.2.Iaa641db08ce7c571860dcce13e4ce056008b711e@changeid (mailing list archive)
State Not Applicable, archived
Headers show
Series [1/2] nvmem: core: constify nvmem_cell_read_variable_common() return value | expand

Commit Message

Doug Anderson May 21, 2021, 9 p.m. UTC
In review feedback Joe Perches found the existing comment
confusing. Let's use something based on the wording proposed by Joe.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/nvmem/qfprom.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Stephen Boyd May 21, 2021, 10:03 p.m. UTC | #1
Quoting Douglas Anderson (2021-05-21 14:00:58)
> In review feedback Joe Perches found the existing comment
> confusing. Let's use something based on the wording proposed by Joe.
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff mbox series

Patch

diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
index 1ba666bcb900..81fbad5e939d 100644
--- a/drivers/nvmem/qfprom.c
+++ b/drivers/nvmem/qfprom.c
@@ -196,9 +196,9 @@  static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
 	}
 
 	/*
-	 * Hardware requires a min voltage for fuse blowing; this may be
-	 * a rail shared do don't specify a max--regulator constraints
-	 * will handle.
+	 * Hardware requires a minimum voltage for fuse blowing.
+	 * This may be a shared rail so don't specify a maximum.
+	 * Regulator constraints will cap to the actual maximum.
 	 */
 	ret = regulator_set_voltage(priv->vcc, qfprom_blow_uV, INT_MAX);
 	if (ret) {