| Message ID | 20220120232028.6738-3-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Multiple addition and improvement to ipq8064 gcc | expand |
On Fri, 21 Jan 2022 00:20:15 +0100, Ansuel Smith wrote: > Simplify qcon,gcc-apq8064 Documentation by using qcom,gcc.yaml as a > template. > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- > .../bindings/clock/qcom,gcc-apq8064.yaml | 27 +++---------------- > 1 file changed, 3 insertions(+), 24 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.example.dt.yaml:0:0: /example-0/clock-controller@900000: failed to match any schema with compatible: ['qcom,gcc-apq8064'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1582347 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Thu, Jan 20, 2022 at 07:37:38PM -0600, Rob Herring wrote: > On Fri, 21 Jan 2022 00:20:15 +0100, Ansuel Smith wrote: > > Simplify qcon,gcc-apq8064 Documentation by using qcom,gcc.yaml as a > > template. > > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > --- > > .../bindings/clock/qcom,gcc-apq8064.yaml | 27 +++---------------- > > 1 file changed, 3 insertions(+), 24 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.example.dt.yaml:0:0: /example-0/clock-controller@900000: failed to match any schema with compatible: ['qcom,gcc-apq8064'] > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1582347 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > Mhh, think these error comes from running the bot with the single change. Or the bot runs the test with the previous commits merged? I don't have these errors on my system with make dt_binding_check.
On Fri, Jan 21, 2022 at 02:41:59AM +0100, Ansuel Smith wrote: > On Thu, Jan 20, 2022 at 07:37:38PM -0600, Rob Herring wrote: > > On Fri, 21 Jan 2022 00:20:15 +0100, Ansuel Smith wrote: > > > Simplify qcon,gcc-apq8064 Documentation by using qcom,gcc.yaml as a > > > template. > > > > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > > --- > > > .../bindings/clock/qcom,gcc-apq8064.yaml | 27 +++---------------- > > > 1 file changed, 3 insertions(+), 24 deletions(-) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.example.dt.yaml:0:0: /example-0/clock-controller@900000: failed to match any schema with compatible: ['qcom,gcc-apq8064'] > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/patch/1582347 > > > > This check can fail if there are any dependencies. The base for a patch > > series is generally the most recent rc1. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit. > > > > Mhh, think these error comes from running the bot with the single change. > Or the bot runs the test with the previous commits merged? It should apply the whole series one by one. However, if patch 1 didn't apply it will still try the rest. It's only smart enough to apply to the last rc1. Given it's the merge window, I suspect you have dependency in the next rc1. Rob
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml index 8e2eac6cbfb9..d65b3fc5bfa1 100644 --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml @@ -6,6 +6,9 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: Qualcomm Global Clock & Reset Controller Binding for APQ8064 +allOf: + - $ref: qcom,gcc.yaml# + maintainers: - Stephen Boyd <sboyd@kernel.org> - Taniya Das <tdas@codeaurora.org> @@ -19,21 +22,6 @@ description: | - dt-bindings/reset/qcom,gcc-msm8960.h properties: - compatible: - const: qcom,gcc-apq8064 - - '#clock-cells': - const: 1 - - '#reset-cells': - const: 1 - - '#power-domain-cells': - const: 1 - - reg: - maxItems: 1 - nvmem-cells: minItems: 1 maxItems: 2 @@ -53,16 +41,7 @@ properties: '#thermal-sensor-cells': const: 1 - protected-clocks: - description: - Protected clock specifier list as per common clock binding. - required: - - compatible - - reg - - '#clock-cells' - - '#reset-cells' - - '#power-domain-cells' - nvmem-cells - nvmem-cell-names - '#thermal-sensor-cells'
Simplify qcon,gcc-apq8064 Documentation by using qcom,gcc.yaml as a template. Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> --- .../bindings/clock/qcom,gcc-apq8064.yaml | 27 +++---------------- 1 file changed, 3 insertions(+), 24 deletions(-)