| Message ID | 20220402155551.16509-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/2] dt-bindings: mailbox: qcom-ipcc: simplify the example | expand |
On Sat, 02 Apr 2022 17:55:50 +0200, Krzysztof Kozlowski wrote: > Consumer examples in the bindings of resource providers are trivial, > useless and duplicating code. Additionally the incomplete qcom,smp2p > example triggers DT schema warnings. > > Cleanup the example by removing the consumer part and fixing the > indentation to DT schema convention. > > Reported-by: Rob Herring <robh@kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/mailbox/qcom-ipcc.yaml | 29 +++++++------------ > 1 file changed, 10 insertions(+), 19 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On 02/04/2022 17:55, Krzysztof Kozlowski wrote: > Consumer examples in the bindings of resource providers are trivial, > useless and duplicating code. Additionally the incomplete qcom,smp2p > example triggers DT schema warnings. > > Cleanup the example by removing the consumer part and fixing the > indentation to DT schema convention. > > Reported-by: Rob Herring <robh@kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Jassi, Do you plan to pick this mailbox patch? Best regards, Krzysztof
On Wed, Apr 20, 2022 at 3:42 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 02/04/2022 17:55, Krzysztof Kozlowski wrote: > > Consumer examples in the bindings of resource providers are trivial, > > useless and duplicating code. Additionally the incomplete qcom,smp2p > > example triggers DT schema warnings. > > > > Cleanup the example by removing the consumer part and fixing the > > indentation to DT schema convention. > > > > Reported-by: Rob Herring <robh@kernel.org> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Jassi, > Do you plan to pick this mailbox patch? > Yes, I do. I am ok too, if you want it through some other tree as a part of some bigger patchset. thanks.
On 20/04/2022 16:22, Jassi Brar wrote: > On Wed, Apr 20, 2022 at 3:42 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 02/04/2022 17:55, Krzysztof Kozlowski wrote: >>> Consumer examples in the bindings of resource providers are trivial, >>> useless and duplicating code. Additionally the incomplete qcom,smp2p >>> example triggers DT schema warnings. >>> >>> Cleanup the example by removing the consumer part and fixing the >>> indentation to DT schema convention. >>> >>> Reported-by: Rob Herring <robh@kernel.org> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> Jassi, >> Do you plan to pick this mailbox patch? >> > Yes, I do. I am ok too, if you want it through some other tree as a > part of some bigger patchset. It's not going through any other tree, so please pick it up. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml index 866efb278813..dfdc72345a2a 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml @@ -61,23 +61,14 @@ additionalProperties: false examples: - | - #include <dt-bindings/interrupt-controller/arm-gic.h> - #include <dt-bindings/mailbox/qcom-ipcc.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/mailbox/qcom-ipcc.h> - mailbox@408000 { - compatible = "qcom,sm8250-ipcc", "qcom,ipcc"; - reg = <0x408000 0x1000>; - interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_HIGH>; - interrupt-controller; - #interrupt-cells = <3>; - #mbox-cells = <2>; - }; - - smp2p-modem { - compatible = "qcom,smp2p"; - interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS - IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>; - mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>; - - /* Other SMP2P fields */ - }; + mailbox@408000 { + compatible = "qcom,sm8250-ipcc", "qcom,ipcc"; + reg = <0x408000 0x1000>; + interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_HIGH>; + interrupt-controller; + #interrupt-cells = <3>; + #mbox-cells = <2>; + };
Consumer examples in the bindings of resource providers are trivial, useless and duplicating code. Additionally the incomplete qcom,smp2p example triggers DT schema warnings. Cleanup the example by removing the consumer part and fixing the indentation to DT schema convention. Reported-by: Rob Herring <robh@kernel.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/mailbox/qcom-ipcc.yaml | 29 +++++++------------ 1 file changed, 10 insertions(+), 19 deletions(-)