| Message ID | 20220402155551.16509-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/2] dt-bindings: mailbox: qcom-ipcc: simplify the example | expand |
On 4/2/22 10:55 AM, Krzysztof Kozlowski wrote: > The example using qcom,smp2p should have all necessary properties, to > avoid DT schema validation warnings. Looks good to me. The particular values don't match any reality, but that doesn't matter for getting the syntactic parse to pass without error or warning. Thanks. Reviewed-by: Alex Elder <elder@linaro.org> > > Reported-by: Rob Herring <robh@kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > index 58ecc62adfaa..dd4bb2e74880 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > @@ -182,6 +182,12 @@ examples: > > smp2p-mpss { > compatible = "qcom,smp2p"; > + interrupts = <GIC_SPI 576 IRQ_TYPE_EDGE_RISING>; > + mboxes = <&apss_shared 6>; > + qcom,smem = <94>, <432>; > + qcom,local-pid = <0>; > + qcom,remote-pid = <5>; > + > ipa_smp2p_out: ipa-ap-to-modem { > qcom,entry-name = "ipa"; > #qcom,smem-state-cells = <1>; > @@ -193,6 +199,7 @@ examples: > #interrupt-cells = <2>; > }; > }; > + > ipa@1e40000 { > compatible = "qcom,sdm845-ipa"; >
On Sat, 02 Apr 2022 17:55:51 +0200, Krzysztof Kozlowski wrote: > The example using qcom,smp2p should have all necessary properties, to > avoid DT schema validation warnings. > > Reported-by: Rob Herring <robh@kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Sat, 02 Apr 2022 17:55:51 +0200, Krzysztof Kozlowski wrote: > The example using qcom,smp2p should have all necessary properties, to > avoid DT schema validation warnings. > > Reported-by: Rob Herring <robh@kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > The netdev folks probably won't pick this up, so applied, thanks!
diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml index 58ecc62adfaa..dd4bb2e74880 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml @@ -182,6 +182,12 @@ examples: smp2p-mpss { compatible = "qcom,smp2p"; + interrupts = <GIC_SPI 576 IRQ_TYPE_EDGE_RISING>; + mboxes = <&apss_shared 6>; + qcom,smem = <94>, <432>; + qcom,local-pid = <0>; + qcom,remote-pid = <5>; + ipa_smp2p_out: ipa-ap-to-modem { qcom,entry-name = "ipa"; #qcom,smem-state-cells = <1>; @@ -193,6 +199,7 @@ examples: #interrupt-cells = <2>; }; }; + ipa@1e40000 { compatible = "qcom,sdm845-ipa";
The example using qcom,smp2p should have all necessary properties, to avoid DT schema validation warnings. Reported-by: Rob Herring <robh@kernel.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/net/qcom,ipa.yaml | 7 +++++++ 1 file changed, 7 insertions(+)