| Message ID | 20221025073254.1564622-4-manivannan.sadhasivam@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | qcom-cpufreq-hw: Add CPU clock provider support | expand |
On 25-10-22, 13:02, Manivannan Sadhasivam wrote: > CPUFreq core will always set the "policy->cpus" bitmask with the bitfield > of the CPU that goes first per domain/policy. So there is no way the > "policy->cpus" bitmask will be empty during qcom_cpufreq_hw_cpu_init(). > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > drivers/cpufreq/qcom-cpufreq-hw.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c > index d5ef3c66c762..a5b3b8d0e164 100644 > --- a/drivers/cpufreq/qcom-cpufreq-hw.c > +++ b/drivers/cpufreq/qcom-cpufreq-hw.c > @@ -552,11 +552,6 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy) > data->per_core_dcvs = true; > > qcom_get_related_cpus(index, policy->cpus); > - if (cpumask_empty(policy->cpus)) { > - dev_err(dev, "Domain-%d failed to get related CPUs\n", index); > - ret = -ENOENT; > - goto error; > - } > > policy->driver_data = data; > policy->dvfs_possible_from_any_cpu = true; Applied. Thanks. I tried applying 4-6 as well, but git am failed. You can send such cleanups separately, so they don't need to wait for others to reviews.
diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c index d5ef3c66c762..a5b3b8d0e164 100644 --- a/drivers/cpufreq/qcom-cpufreq-hw.c +++ b/drivers/cpufreq/qcom-cpufreq-hw.c @@ -552,11 +552,6 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy) data->per_core_dcvs = true; qcom_get_related_cpus(index, policy->cpus); - if (cpumask_empty(policy->cpus)) { - dev_err(dev, "Domain-%d failed to get related CPUs\n", index); - ret = -ENOENT; - goto error; - } policy->driver_data = data; policy->dvfs_possible_from_any_cpu = true;
CPUFreq core will always set the "policy->cpus" bitmask with the bitfield of the CPU that goes first per domain/policy. So there is no way the "policy->cpus" bitmask will be empty during qcom_cpufreq_hw_cpu_init(). Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- drivers/cpufreq/qcom-cpufreq-hw.c | 5 ----- 1 file changed, 5 deletions(-)