| Message ID | 20221029051449.30678-6-manivannan.sadhasivam@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | sc8280xp-pmic updates and X13s thermal zone support | expand |
On 29.10.2022 07:14, Manivannan Sadhasivam wrote: > Add support for ADC7 block available in PMK8280 for reading the > temperature via the AMUX pins. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > index 4a3464f5e6e9..3c56e4cb5b5b 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > @@ -75,6 +75,15 @@ pmk8280_pon_resin: resin { > status = "disabled"; > }; > }; > + > + pmk8280_vadc: adc@3100 { > + compatible = "qcom,spmi-adc7"; > + reg = <0x3100>; > + #address-cells = <1>; > + #size-cells = <0>; > + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>; > + #io-channel-cells = <1>; Maybe having interrupts after reg and all the -cells below that would look better. For the contents though: Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Konrad > + }; > }; > > pmc8280_1: pmic@1 {
On 29.10.2022 16:15, Konrad Dybcio wrote: > > > On 29.10.2022 07:14, Manivannan Sadhasivam wrote: >> Add support for ADC7 block available in PMK8280 for reading the >> temperature via the AMUX pins. >> >> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >> --- >> arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi >> index 4a3464f5e6e9..3c56e4cb5b5b 100644 >> --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi >> @@ -75,6 +75,15 @@ pmk8280_pon_resin: resin { >> status = "disabled"; >> }; >> }; >> + >> + pmk8280_vadc: adc@3100 { >> + compatible = "qcom,spmi-adc7"; >> + reg = <0x3100>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>; >> + #io-channel-cells = <1>; > Maybe having interrupts after reg and all the -cells below that would look better. > > For the contents though: > > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > > Konrad Sorry for double noise, I just noticed you didn't disable this by default. Was that intended? Konrad >> + }; >> }; >> >> pmc8280_1: pmic@1 {
On 29/10/2022 01:14, Manivannan Sadhasivam wrote: > Add support for ADC7 block available in PMK8280 for reading the > temperature via the AMUX pins. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 9 +++++++++ Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi index 4a3464f5e6e9..3c56e4cb5b5b 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi @@ -75,6 +75,15 @@ pmk8280_pon_resin: resin { status = "disabled"; }; }; + + pmk8280_vadc: adc@3100 { + compatible = "qcom,spmi-adc7"; + reg = <0x3100>; + #address-cells = <1>; + #size-cells = <0>; + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>; + #io-channel-cells = <1>; + }; }; pmc8280_1: pmic@1 {
Add support for ADC7 block available in PMK8280 for reading the temperature via the AMUX pins. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)