diff mbox series

[v3,1/3] arm64: dts: qcom: sdm845-db845c: fix audio codec interrupt pin name

Message ID 20221202155738.383301-1-krzysztof.kozlowski@linaro.org (mailing list archive)
State Superseded
Headers show
Series [v3,1/3] arm64: dts: qcom: sdm845-db845c: fix audio codec interrupt pin name | expand

Commit Message

Krzysztof Kozlowski Dec. 2, 2022, 3:57 p.m. UTC
The pin config entry should have a string, not number, for the GPIO used
as WCD9340 audio codec interrupt.

Reported-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Cc: Doug Anderson <dianders@chromium.org>

Changes since v2:
1. New patch.
---
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Doug Anderson Dec. 2, 2022, 4:08 p.m. UTC | #1
Hi,

On Fri, Dec 2, 2022 at 7:57 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> The pin config entry should have a string, not number, for the GPIO used
> as WCD9340 audio codec interrupt.
>
> Reported-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Doug Anderson <dianders@chromium.org>
>
> Changes since v2:
> 1. New patch.
> ---
>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Presumably should have a "Fixes" tag since this is likely a true bug.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Doug Anderson Dec. 2, 2022, 4:18 p.m. UTC | #2
Hi,

On Fri, Dec 2, 2022 at 8:08 AM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Fri, Dec 2, 2022 at 7:57 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> >
> > The pin config entry should have a string, not number, for the GPIO used
> > as WCD9340 audio codec interrupt.
> >
> > Reported-by: Doug Anderson <dianders@chromium.org>
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > ---
> >
> > Cc: Doug Anderson <dianders@chromium.org>
> >
> > Changes since v2:
> > 1. New patch.
> > ---
> >  arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Presumably should have a "Fixes" tag since this is likely a true bug.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

FWIW, this got copy-pasta-ed to another place, which I just noticed as
I'm looking at your v3. So while your change is correct, it'd be
better to also fix "sdm845-xiaomi-beryllium-common.dtsi"

-Doug
Krzysztof Kozlowski Dec. 2, 2022, 4:26 p.m. UTC | #3
On 02/12/2022 17:18, Doug Anderson wrote:
> Hi,
> 
> On Fri, Dec 2, 2022 at 8:08 AM Doug Anderson <dianders@chromium.org> wrote:
>>
>> Hi,
>>
>> On Fri, Dec 2, 2022 at 7:57 AM Krzysztof Kozlowski
>> <krzysztof.kozlowski@linaro.org> wrote:
>>>
>>> The pin config entry should have a string, not number, for the GPIO used
>>> as WCD9340 audio codec interrupt.
>>>
>>> Reported-by: Doug Anderson <dianders@chromium.org>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>> ---
>>>
>>> Cc: Doug Anderson <dianders@chromium.org>
>>>
>>> Changes since v2:
>>> 1. New patch.
>>> ---
>>>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Presumably should have a "Fixes" tag since this is likely a true bug.
>>
>> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> 
> FWIW, this got copy-pasta-ed to another place, which I just noticed as
> I'm looking at your v3. So while your change is correct, it'd be
> better to also fix "sdm845-xiaomi-beryllium-common.dtsi"

Yep...

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index 3e7ceb0861eb..f324c0af665b 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -979,7 +979,7 @@  sdc2_card_det_n: sd-card-det-n {
 	};
 
 	wcd_intr_default: wcd_intr_default {
-		pins = <54>;
+		pins = "gpio54";
 		function = "gpio";
 
 		input-enable;