diff mbox series

[18/18] arm64: dts: qcom: sdm845-polaris: add missing touchscreen child node reg

Message ID 20230419211856.79332-18-krzysztof.kozlowski@linaro.org (mailing list archive)
State Accepted
Headers show
Series [01/18] arm64: dts: qcom: ipq6018: correct qrng unit address | expand

Commit Message

Krzysztof Kozlowski April 19, 2023, 9:18 p.m. UTC
Add missing reg property to touchscreen child node to fix dtbs W=1 warnings:

  Warning (unit_address_vs_reg): /soc@0/geniqup@ac0000/i2c@a98000/touchscreen@20/rmi4-f12@12: node has a unit name, but no reg or ranges property

Fixes: be497abe19bf ("arm64: dts: qcom: Add support for Xiaomi Mi Mix2s")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Molly Sophia April 20, 2023, 9:40 a.m. UTC | #1
On Thu, Apr 20, 2023 at 5:19 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Add missing reg property to touchscreen child node to fix dtbs W=1 warnings:
>
>   Warning (unit_address_vs_reg): /soc@0/geniqup@ac0000/i2c@a98000/touchscreen@20/rmi4-f12@12: node has a unit name, but no reg or ranges property
>
> Fixes: be497abe19bf ("arm64: dts: qcom: Add support for Xiaomi Mi Mix2s")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> index 8ae0ffccaab2..576f0421824f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> @@ -483,6 +483,7 @@ rmi4-f01@1 {
>                 };
>
>                 rmi4-f12@12 {
> +                       reg = <0x12>;
>                         syna,rezero-wait-ms = <0xc8>;
>                         syna,clip-x-high = <0x438>;
>                         syna,clip-y-high = <0x870>;
> --
> 2.34.1
>

Reviewed-by: Molly Sophia <mollysophia379@gmail.com>
Konrad Dybcio April 20, 2023, 10:56 a.m. UTC | #2
On 19.04.2023 23:18, Krzysztof Kozlowski wrote:
> Add missing reg property to touchscreen child node to fix dtbs W=1 warnings:
> 
>   Warning (unit_address_vs_reg): /soc@0/geniqup@ac0000/i2c@a98000/touchscreen@20/rmi4-f12@12: node has a unit name, but no reg or ranges property
> 
> Fixes: be497abe19bf ("arm64: dts: qcom: Add support for Xiaomi Mi Mix2s")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> index 8ae0ffccaab2..576f0421824f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> @@ -483,6 +483,7 @@ rmi4-f01@1 {
>  		};
>  
>  		rmi4-f12@12 {
> +			reg = <0x12>;
>  			syna,rezero-wait-ms = <0xc8>;
>  			syna,clip-x-high = <0x438>;
>  			syna,clip-y-high = <0x870>;
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
index 8ae0ffccaab2..576f0421824f 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
@@ -483,6 +483,7 @@  rmi4-f01@1 {
 		};
 
 		rmi4-f12@12 {
+			reg = <0x12>;
 			syna,rezero-wait-ms = <0xc8>;
 			syna,clip-x-high = <0x438>;
 			syna,clip-y-high = <0x870>;