| Message ID | 20230601152026.1182648-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/8] pinctrl: qcom: qdf2xxx: drop ACPI_PTR | expand |
Thu, Jun 01, 2023 at 05:20:19PM +0200, Krzysztof Kozlowski kirjoitti: > Driver can bind only via ACPI matching and acpi_device_id is there > unconditionally, so drop useless ACPI_PTR() macro. With this acpi.h becomes unused and has to be replaced with (AFAICT) property.h mod_devicetable.h (maybe others, but I haven't checked deeply) With that, Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c > index b0f1b3dc6831..b5808fcfb13c 100644 > --- a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c > +++ b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c > @@ -142,7 +142,7 @@ MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids); > static struct platform_driver qdf2xxx_pinctrl_driver = { > .driver = { > .name = "qdf2xxx-pinctrl", > - .acpi_match_table = ACPI_PTR(qdf2xxx_acpi_ids), > + .acpi_match_table = qdf2xxx_acpi_ids, > }, > .probe = qdf2xxx_pinctrl_probe, > .remove = msm_pinctrl_remove, > -- > 2.34.1 >
On 1.06.2023 17:20, Krzysztof Kozlowski wrote: > Driver can bind only via ACPI matching and acpi_device_id is there > unconditionally, so drop useless ACPI_PTR() macro. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Oh I forgot this SoC existed... I wish I could play with it! Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c > index b0f1b3dc6831..b5808fcfb13c 100644 > --- a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c > +++ b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c > @@ -142,7 +142,7 @@ MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids); > static struct platform_driver qdf2xxx_pinctrl_driver = { > .driver = { > .name = "qdf2xxx-pinctrl", > - .acpi_match_table = ACPI_PTR(qdf2xxx_acpi_ids), > + .acpi_match_table = qdf2xxx_acpi_ids, > }, > .probe = qdf2xxx_pinctrl_probe, > .remove = msm_pinctrl_remove,
On Thu, Jun 1, 2023 at 5:20 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Driver can bind only via ACPI matching and acpi_device_id is there > unconditionally, so drop useless ACPI_PTR() macro. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Patches applied! I had to manually update patch 7/8 to account for the IPQ5018 driver that I just applied, but I think I figured it out, check the result! Yours, Linus Walleij
On 09/06/2023 09:12, Linus Walleij wrote: > On Thu, Jun 1, 2023 at 5:20 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > >> Driver can bind only via ACPI matching and acpi_device_id is there >> unconditionally, so drop useless ACPI_PTR() macro. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Patches applied! > > I had to manually update patch 7/8 to account for the IPQ5018 driver that > I just applied, but I think I figured it out, check the result! Thanks, looks good! Best regards, Krzysztof
diff --git a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c index b0f1b3dc6831..b5808fcfb13c 100644 --- a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c +++ b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c @@ -142,7 +142,7 @@ MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids); static struct platform_driver qdf2xxx_pinctrl_driver = { .driver = { .name = "qdf2xxx-pinctrl", - .acpi_match_table = ACPI_PTR(qdf2xxx_acpi_ids), + .acpi_match_table = qdf2xxx_acpi_ids, }, .probe = qdf2xxx_pinctrl_probe, .remove = msm_pinctrl_remove,
Driver can bind only via ACPI matching and acpi_device_id is there unconditionally, so drop useless ACPI_PTR() macro. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)