Message ID | 20230613001004.3426676-4-dmitry.baryshkov@linaro.org (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | drm/msm/dpu: another catalog rework | expand |
On 6/12/2023 5:09 PM, Dmitry Baryshkov wrote: > sm6115 and qcm2290 do not have INTF_0. Drop corresponding interface > definitions. > And sm6375 as you are touching that too > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- You can fix that while applying. Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
On 2023-06-13 03:09:42, Dmitry Baryshkov wrote: > sm6115 and qcm2290 do not have INTF_0. Drop corresponding interface > definitions. As Abhinav said, add sm6375. If it wasn't for sc8280xp using INTF_NONE for fake MST, we could have dropped INTF_NONE and the special-cases in dpu_hw_interrupts.c and dpu_hw_intf.c entirely! Is that your plan? > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_3_sm6115.h | 1 - > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h | 1 - > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_3_sm6115.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_3_sm6115.h > index ba9de008519b..031fc8dae3c6 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_3_sm6115.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_3_sm6115.h > @@ -66,7 +66,6 @@ static const struct dpu_pingpong_cfg sm6115_pp[] = { > }; > > static const struct dpu_intf_cfg sm6115_intf[] = { > - INTF_BLK("intf_0", INTF_0, 0x00000, 0x280, INTF_NONE, 0, 0, 0, 0, 0), > INTF_BLK_DSI_TE("intf_1", INTF_1, 0x6a800, 0x2c0, INTF_DSI, 0, 24, INTF_SC7180_MASK, > DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 26), > DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 27), > diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h > index 92ac348eea6b..f2808098af39 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h > @@ -63,7 +63,6 @@ static const struct dpu_pingpong_cfg qcm2290_pp[] = { > }; > > static const struct dpu_intf_cfg qcm2290_intf[] = { > - INTF_BLK("intf_0", INTF_0, 0x00000, 0x280, INTF_NONE, 0, 0, 0, 0, 0), > INTF_BLK_DSI_TE("intf_1", INTF_1, 0x6a800, 0x2c0, INTF_DSI, 0, 24, INTF_SC7180_MASK, > DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 26), > DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 27), > diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h > index d7aae45e3e66..241fa6746674 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h > @@ -71,7 +71,6 @@ static const struct dpu_dsc_cfg sm6375_dsc[] = { > }; > > static const struct dpu_intf_cfg sm6375_intf[] = { > - INTF_BLK("intf_0", INTF_0, 0x00000, 0x280, INTF_NONE, 0, 0, 0, 0, 0), > INTF_BLK_DSI_TE("intf_1", INTF_1, 0x6a800, 0x2c0, INTF_DSI, 0, 24, INTF_SC7180_MASK, > DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 26), > DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 27), > -- > 2.39.2 >
On 16/06/2023 01:26, Marijn Suijten wrote: > On 2023-06-13 03:09:42, Dmitry Baryshkov wrote: >> sm6115 and qcm2290 do not have INTF_0. Drop corresponding interface >> definitions. > > As Abhinav said, add sm6375. > > If it wasn't for sc8280xp using INTF_NONE for fake MST, we could have > dropped INTF_NONE and the special-cases in dpu_hw_interrupts.c and > dpu_hw_intf.c entirely! Is that your plan? I have not thought about it yet. Generally I think INTF_NONE might still be useful to document interfaces that we do not want to support for some reason (e.g. MST or 8974/8084 eDP interfaces). > >> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> >
On 2023-06-16 12:49:29, Dmitry Baryshkov wrote: > On 16/06/2023 01:26, Marijn Suijten wrote: > > On 2023-06-13 03:09:42, Dmitry Baryshkov wrote: > >> sm6115 and qcm2290 do not have INTF_0. Drop corresponding interface > >> definitions. > > > > As Abhinav said, add sm6375. > > > > If it wasn't for sc8280xp using INTF_NONE for fake MST, we could have > > dropped INTF_NONE and the special-cases in dpu_hw_interrupts.c and > > dpu_hw_intf.c entirely! Is that your plan? > > I have not thought about it yet. Generally I think INTF_NONE might still > be useful to document interfaces that we do not want to support for some > reason (e.g. MST or 8974/8084 eDP interfaces). Sounds good, then we only use it for existing but specialcase interfaces rather than for bogus/empty entries in the catalog! - Marijn > > > >> > >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > > > > -- > With best wishes > Dmitry >
diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_3_sm6115.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_3_sm6115.h index ba9de008519b..031fc8dae3c6 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_3_sm6115.h +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_3_sm6115.h @@ -66,7 +66,6 @@ static const struct dpu_pingpong_cfg sm6115_pp[] = { }; static const struct dpu_intf_cfg sm6115_intf[] = { - INTF_BLK("intf_0", INTF_0, 0x00000, 0x280, INTF_NONE, 0, 0, 0, 0, 0), INTF_BLK_DSI_TE("intf_1", INTF_1, 0x6a800, 0x2c0, INTF_DSI, 0, 24, INTF_SC7180_MASK, DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 26), DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 27), diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h index 92ac348eea6b..f2808098af39 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h @@ -63,7 +63,6 @@ static const struct dpu_pingpong_cfg qcm2290_pp[] = { }; static const struct dpu_intf_cfg qcm2290_intf[] = { - INTF_BLK("intf_0", INTF_0, 0x00000, 0x280, INTF_NONE, 0, 0, 0, 0, 0), INTF_BLK_DSI_TE("intf_1", INTF_1, 0x6a800, 0x2c0, INTF_DSI, 0, 24, INTF_SC7180_MASK, DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 26), DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 27), diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h index d7aae45e3e66..241fa6746674 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h @@ -71,7 +71,6 @@ static const struct dpu_dsc_cfg sm6375_dsc[] = { }; static const struct dpu_intf_cfg sm6375_intf[] = { - INTF_BLK("intf_0", INTF_0, 0x00000, 0x280, INTF_NONE, 0, 0, 0, 0, 0), INTF_BLK_DSI_TE("intf_1", INTF_1, 0x6a800, 0x2c0, INTF_DSI, 0, 24, INTF_SC7180_MASK, DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 26), DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 27),
sm6115 and qcm2290 do not have INTF_0. Drop corresponding interface definitions. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_3_sm6115.h | 1 - drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h | 1 - drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h | 1 - 3 files changed, 3 deletions(-)