| Message ID | 20240329-v2-dts-add-support-for-samsung-galaxy-zfold5-v1-2-9a91e635cacc@yahoo.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | V2 arm64: dts: qcom: Add support for Samsung Galaxy Z Fold5 | expand |
On 29.03.2024 12:08 AM, Alexandru Marc Serdeliuc via B4 Relay wrote: > From: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > > Add support for Samsung Galaxy Z Fold5 (q5q) foldable phone > > Currently working features: > - Framebuffer > - UFS > - i2c > - Buttons > > Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > --- Looks like the commit message and contents got mixed up! Konrad
Thanks, indeed, v3 will contain the right messages On 29/3/24 1:54, Konrad Dybcio wrote: > On 29.03.2024 12:08 AM, Alexandru Marc Serdeliuc via B4 Relay wrote: >> From: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> >> >> Add support for Samsung Galaxy Z Fold5 (q5q) foldable phone >> >> Currently working features: >> - Framebuffer >> - UFS >> - i2c >> - Buttons >> >> Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> >> --- > Looks like the commit message and contents got mixed up! > > Konrad
Thanks, indeed, v3 will contain the right messages On 29/3/24 1:54, Konrad Dybcio wrote: > On 29.03.2024 12:08 AM, Alexandru Marc Serdeliuc via B4 Relay wrote: >> From: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> >> >> Add support for Samsung Galaxy Z Fold5 (q5q) foldable phone >> >> Currently working features: >> - Framebuffer >> - UFS >> - i2c >> - Buttons >> >> Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> >> --- > Looks like the commit message and contents got mixed up! > > Konrad
On 29/03/2024 00:08, Alexandru Marc Serdeliuc via B4 Relay wrote: > From: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > > Add support for Samsung Galaxy Z Fold5 (q5q) foldable phone Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. v2 is for sure wrong prefix. Other parts are also wrong, which above command will tell you. > > Currently working features: > - Framebuffer > - UFS > - i2c > - Buttons > > Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> Please go back and read my response. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 66beaac60e1d..dea2a23b8fc2 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -1003,6 +1003,7 @@ properties: - qcom,sm8550-hdk - qcom,sm8550-mtp - qcom,sm8550-qrd + - samsung,q5q - const: qcom,sm8550 - items: