[v3,0/4] clk: qcom: rpm: drop platform names

Message

Dmitry Baryshkov Dec. 2, 2022, 7:08 a.m. UTC

The RPM clocks driver uses platform (SoC) as a part of the clock
definition. However there is nothing really SoC-specific in this
part. Using it just leads to confusion and sometimes to duplication of
definitions. Drop the SoC name where it is logical.

Changes since v2:
- Split from the RPMH patchset
- Dropped superfluous active-only clock names when there are no actual
  clocks behind
- Removed the _clk and _a_clk suffixes, moving them to preprocessor
  macro, no need to have them all over the code.

Dmitry Baryshkov (4):
  clk: qcom: rpm: remove unused active-only clock names
  clk: qcom: rpm: drop separate active-only names
  clk: qcom: rpm: drop the _clk suffix completely
  clk: qcom: rpm: drop the platform from clock definitions

 drivers/clk/qcom/clk-rpm.c | 204 +++++++++++++++++--------------------
 1 file changed, 94 insertions(+), 110 deletions(-)

Comments

Bjorn Andersson Dec. 2, 2022, 7:42 p.m. UTC | #1

On Fri, Dec 02, 2022 at 09:08:10AM +0200, Dmitry Baryshkov wrote:
> The RPM clocks driver uses platform (SoC) as a part of the clock
> definition. However there is nothing really SoC-specific in this
> part. Using it just leads to confusion and sometimes to duplication of
> definitions. Drop the SoC name where it is logical.

Reviewed-by: Bjorn Andersson <[e-mail]>

Regards,
Bjorn

> 
> Changes since v2:
> - Split from the RPMH patchset
> - Dropped superfluous active-only clock names when there are no actual
>   clocks behind
> - Removed the _clk and _a_clk suffixes, moving them to preprocessor
>   macro, no need to have them all over the code.
> 
> Dmitry Baryshkov (4):
>   clk: qcom: rpm: remove unused active-only clock names
>   clk: qcom: rpm: drop separate active-only names
>   clk: qcom: rpm: drop the _clk suffix completely
>   clk: qcom: rpm: drop the platform from clock definitions
> 
>  drivers/clk/qcom/clk-rpm.c | 204 +++++++++++++++++--------------------
>  1 file changed, 94 insertions(+), 110 deletions(-)
> 
> -- 
> 2.35.1
>

Bjorn Andersson Dec. 2, 2022, 8:58 p.m. UTC | #2

On Fri, 2 Dec 2022 09:08:10 +0200, Dmitry Baryshkov wrote:
> The RPM clocks driver uses platform (SoC) as a part of the clock
> definition. However there is nothing really SoC-specific in this
> part. Using it just leads to confusion and sometimes to duplication of
> definitions. Drop the SoC name where it is logical.
> 
> Changes since v2:
> - Split from the RPMH patchset
> - Dropped superfluous active-only clock names when there are no actual
>   clocks behind
> - Removed the _clk and _a_clk suffixes, moving them to preprocessor
>   macro, no need to have them all over the code.
> 
> [...]

Applied, thanks!

[1/4] clk: qcom: rpm: remove unused active-only clock names
      commit: fbd5a2cbdab5fe7678a823209c76bf9f876f1448
[2/4] clk: qcom: rpm: drop separate active-only names
      commit: 35a57cdae7433e1aab1a8c0e06197d368bc4de8a
[3/4] clk: qcom: rpm: drop the _clk suffix completely
      commit: e9bf411a5deeb86379ca94bdb64067656ae5e138
[4/4] clk: qcom: rpm: drop the platform from clock definitions
      commit: 3de1c1fd6189c64e6e026780bb244f878fdb0a23

Best regards,