diff mbox series

[v2,2/5] clk: Enable/Disable runtime PM for clk_summary

Message ID 1640018638-19436-3-git-send-email-tdas@codeaurora.org (mailing list archive)
State Accepted, archived
Headers show
Series Add support for LPASS Core and Audio Clock for SC7280 | expand

Commit Message

Taniya Das Dec. 20, 2021, 4:43 p.m. UTC
The registers for some clocks in the SOC area, which are under the power
domain are required to be enabled before accessing them. During the
clk_summary if the power-domains are not enabled they could result into
NoC errors.

Thus ensure the register access of the clock controller is done with
pm_untime_get/put functions.

Signed-off-by: Taniya Das <tdas@codeaurora.org>
---
 drivers/clk/clk.c | 2 ++
 1 file changed, 2 insertions(+)

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the  Linux Foundation.

Comments

Stephen Boyd Jan. 6, 2022, 1:20 a.m. UTC | #1
Quoting Taniya Das (2021-12-20 08:43:55)
> The registers for some clocks in the SOC area, which are under the power
> domain are required to be enabled before accessing them. During the
> clk_summary if the power-domains are not enabled they could result into
> NoC errors.
> 
> Thus ensure the register access of the clock controller is done with
> pm_untime_get/put functions.
> 
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 963f56f..8de6a22 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2966,7 +2966,9 @@  static void clk_summary_show_subtree(struct seq_file *s, struct clk_core *c,
 {
 	struct clk_core *child;

+	clk_pm_runtime_get(c);
 	clk_summary_show_one(s, c, level);
+	clk_pm_runtime_put(c);

 	hlist_for_each_entry(child, &c->children, child_node)
 		clk_summary_show_subtree(s, child, level + 1);