diff mbox

Crypto Update for 4.1

Message ID CAKv+Gu8s=-qyX9MAcpyd39AtBVCa-+Ly1ue1zBwam_bHqqJuvg@mail.gmail.com (mailing list archive)
State Superseded
Headers show

Commit Message

Ard Biesheuvel April 23, 2015, 8:10 p.m. UTC 
On 23 April 2015 at 21:27, Bobby Powers <bobbypowers@gmail.com> wrote:
> Hello,
>
> Linus Torvalds <torvalds@linux-foundation.org> wrote:
>> Ok, this patch seems to fix it for me, so I undid my revert that I
>> hadn't pushed out yet, and pushed out this instead.
>
> Commit e68410ebf62676dfb93aafff7c55b76644f37072 in Linus's tree from
> this crpyto update (crypto: x86/sha512_ssse3 - move SHA-384/512 SSSE3
> implementation to base layer) causes a GPF on boot in
> sha512_ssse3_finup for me on a Broadwell i7-5600U, rendering the
> kernel unbootable.
>
> Reverting that commit enables me to boot.  I don't know enough about
> the code to comment.  Config is attached, and I can provide a photo of
> the reported Call Trace if thats helpful.  It is quite reproducible
> for me.
>

Hello Bobby,

Would you be able to check whether the following patch fixes the crash?

If not, please share the call trace and the content of /proc/cpuinfo

Regards,
Ard.
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Bobby Powers April 23, 2015, 9:35 p.m. UTC | #1 
On Thu, Apr 23, 2015 at 4:10 PM, Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
>
> Hello Bobby,
>
> Would you be able to check whether the following patch fixes the crash?
>
> diff --git a/arch/x86/crypto/sha512-avx2-asm.S
> b/arch/x86/crypto/sha512-avx2-asm.S
> index a4771dcd1fcf..1f20b35d8573 100644
> --- a/arch/x86/crypto/sha512-avx2-asm.S
> +++ b/arch/x86/crypto/sha512-avx2-asm.S
> @@ -79,7 +79,7 @@ NUM_BLKS    = %rdx
>  c           = %rcx
>  d           = %r8
>  e           = %rdx
> -y3          = %rdi
> +y3          = %rsi
>
>  TBL   = %rbp
>

Tested-By: Bobby Powers <bobbypowers@gmail.com>


Thanks Ard.  Yes, this fixes things for me.  Good eye :)

yours,
Bobby
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/x86/crypto/sha512-avx2-asm.S
b/arch/x86/crypto/sha512-avx2-asm.S
index a4771dcd1fcf..1f20b35d8573 100644
--- a/arch/x86/crypto/sha512-avx2-asm.S
+++ b/arch/x86/crypto/sha512-avx2-asm.S
@@ -79,7 +79,7 @@  NUM_BLKS    = %rdx
 c           = %rcx
 d           = %r8
 e           = %rdx
-y3          = %rdi
+y3          = %rsi

 TBL   = %rbp