| Message ID | 6c6ecf7eee7d41492dbbcc4410db7eefd1fbb13d.1617776878.git.pavle.rohalj@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | *** SUBJECT HERE *** | expand |
On Tue, Apr 06, 2021 at 11:36:01PM -0700, Pavle Rohalj wrote: > Fix "Avoid CamelCase" checkpatch.pl checks for the function dviInit and > its parameter names in ddk750_dvi.h. > > Signed-off-by: Pavle Rohalj <pavle.rohalj@gmail.com> > --- > drivers/staging/sm750fb/ddk750_dvi.c | 2 +- > drivers/staging/sm750fb/ddk750_dvi.h | 20 ++++++++++---------- > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c > index db19bf732482..943cbcafcffa 100644 > --- a/drivers/staging/sm750fb/ddk750_dvi.c > +++ b/drivers/staging/sm750fb/ddk750_dvi.c > @@ -30,7 +30,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { > #endif > }; > > -int dviInit(unsigned char edge_select, > +int dvi_init(unsigned char edge_select, Why is this a global function? Just make it static and remove it from the .h file. thanks, greg k-h
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c index db19bf732482..943cbcafcffa 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.c +++ b/drivers/staging/sm750fb/ddk750_dvi.c @@ -30,7 +30,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { #endif }; -int dviInit(unsigned char edge_select, +int dvi_init(unsigned char edge_select, unsigned char bus_select, unsigned char dual_edge_clk_select, unsigned char hsync_enable, diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h index 4ca2591ea94b..fbc897c7efb8 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.h +++ b/drivers/staging/sm750fb/ddk750_dvi.h @@ -42,16 +42,16 @@ struct dvi_ctrl_device { #define DVI_CTRL_SII164 /* dvi functions prototype */ -int dviInit(unsigned char edgeSelect, - unsigned char busSelect, - unsigned char dualEdgeClkSelect, - unsigned char hsyncEnable, - unsigned char vsyncEnable, - unsigned char deskewEnable, - unsigned char deskewSetting, - unsigned char continuousSyncEnable, - unsigned char pllFilterEnable, - unsigned char pllFilterValue); +int dvi_init(unsigned char edge_select, + unsigned char bus_select, + unsigned char dual_edge_clk_select, + unsigned char hsync_enable, + unsigned char vsync_enable, + unsigned char deskew_enable, + unsigned char deskew_setting, + unsigned char continuous_sync_enable, + unsigned char pll_filter_enable, + unsigned char pll_filter_value); #endif
Fix "Avoid CamelCase" checkpatch.pl checks for the function dviInit and its parameter names in ddk750_dvi.h. Signed-off-by: Pavle Rohalj <pavle.rohalj@gmail.com> --- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_dvi.h | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-)