Q. set_cached_acl() on NFSv3

Commit Message

J. R. Okajima March 24, 2019, 2:46 a.m. UTC

By the commit for v5.1-rc1,
	ded52fbe7020 2019-02-20 nfs: fix xfstest generic/099 failed on nfsv3
NFSv3 stopped calling set_cached_acl().
And the behaviour changed.  Is this intentional?

Here is the example.

(test script)
f=fileA
> $f
getfacl --omit-header $f |
tee $tmp
setfacl -m u:$USER:rx,g:nogroup:x $f
getfacl --omit-header $f |
+ :
+ setfacl -x u:jro,g:nogroup fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/2351 -

(there is no diff output)

Patch

diff -u $tmp - || :
setfacl -x u:$USER,g:nogroup $f
getfacl --omit-header $f |
diff -u $tmp - || :

- on linux-v5.0, there is no difference between ext4 and nfs3.
- on linux-v5.1-rc1, ext4 behaves same, but nfs3 doesn't show the "mask"
  entry in the last output.
- removing user:$USER and group:nogroup entries looks "mask" entry gone
  too.


J. R. Okajima


########################################
linux-v5.0
ext4

+ getfacl --omit-header fileA
+ tee /tmp/6311
user::rw-
group::r--
other::r--

+ setfacl -m u:jro:rx,g:nogroup:x fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/6311 -
--- /tmp/6311	2019-03-24 11:16:18.000000000 +0900
+++ -	2019-03-24 11:16:18.053867096 +0900
@@ -1,4 +1,7 @@ 
 user::rw-
+user:jro:r-x
 group::r--
+group:nogroup:--x
+mask::r-x
 other::r--

+ setfacl -x u:jro,g:nogroup fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/6311 -
--- /tmp/6311	2019-03-24 11:16:18.000000000 +0900
+++ -	2019-03-24 11:16:18.062265271 +0900
@@ -1,4 +1,5 @@ 
 user::rw-
 group::r--
+mask::r--
 other::r--

########################################
linux-v5.0
nfs3

+ getfacl --omit-header fileA
+ tee  /tmp/6579
user::rw-
group::r--
other::r--

+ setfacl -m u:jro:rx,g:nogroup:x fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/6579 -
--- /tmp/6579	2019-03-24 11:16:27.000000000 +0900
+++ -	2019-03-24 11:16:27.360407625 +0900
@@ -1,4 +1,7 @@ 
 user::rw-
+user:jro:r-x
 group::r--
+group:nogroup:--x
+mask::r-x
 other::r--

+ :
+ setfacl -x u:jro,g:nogroup fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/6579 -
--- /tmp/6579	2019-03-24 11:16:27.000000000 +0900
+++ -	2019-03-24 11:16:27.369262067 +0900
@@ -1,4 +1,5 @@ 
 user::rw-
 group::r--
+mask::r--
 other::r--

########################################
linux-v5.1-rc1
ext4

+ f=fileA
+
+ getfacl --omit-header fileA
+ tee /tmp/2065
user::rw-
group::r--
other::r--

+ setfacl -m u:jro:rx,g:nogroup:x fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/2065 -
--- /tmp/2065	2019-03-24 11:19:24.000000000 +0900
+++ -	2019-03-24 11:19:24.223903353 +0900
@@ -1,4 +1,7 @@ 
 user::rw-
+user:jro:r-x
 group::r--
+group:nogroup:--x
+mask::r-x
 other::r--

+ :
+ setfacl -x u:jro,g:nogroup fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/2065 -
--- /tmp/2065	2019-03-24 11:19:24.000000000 +0900
+++ -	2019-03-24 11:19:24.230741358 +0900
@@ -1,4 +1,5 @@ 
 user::rw-
 group::r--
+mask::r--
 other::r--

########################################
linux-v5.1-rc1
nfs3

+ f=fileA
+
+ getfacl --omit-header fileA
+ tee /tmp/2351
user::rw-
group::r--
other::r--

+ setfacl -m u:jro:rx,g:nogroup:x fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/2351 -
--- /tmp/2351	2019-03-24 11:19:30.000000000 +0900
+++ -	2019-03-24 11:19:30.706744795 +0900
@@ -1,4 +1,7 @@ 
 user::rw-
+user:jro:r-x
 group::r--
+group:nogroup:--x
+mask::r-x
 other::r--