| Message ID | 20200325031433.28223-2-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] kconfig: remove unused variable in qconf.cc | expand |
On Wed, Mar 25, 2020 at 12:14:32PM +0900, Masahiro Yamada wrote: > Add -Wall to catch more warnings for C++ host programs. > > When I submitted the previous version, the 0-day bot reported > -Wc++11-compat warnings for old GCC: > > HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o > In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:28:0, > from scripts/gcc-plugins/gcc-common.h:15, > from scripts/gcc-plugins/latent_entropy_plugin.c:78: > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:102:21: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ > ^ > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:170:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ > ^ > In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:42:0, > from scripts/gcc-plugins/gcc-common.h:15, > from scripts/gcc-plugins/latent_entropy_plugin.c:78: > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/defaults.h:126:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ > ^ > > The source of the warnings is in the plugin headers, so we have no > control of it. I just suppressed them by adding -Wno-c++11-compat to > scripts/gcc-plugins/Makefile. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Acked-by: Kees Cook <keescook@chromium.org> -Kees > --- > > Makefile | 2 +- > scripts/gcc-plugins/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 3b57ccab367b..593d8f1bbe90 100644 > --- a/Makefile > +++ b/Makefile > @@ -400,7 +400,7 @@ HOSTCXX = g++ > KBUILD_HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \ > -fomit-frame-pointer -std=gnu89 $(HOST_LFS_CFLAGS) \ > $(HOSTCFLAGS) > -KBUILD_HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS) $(HOSTCXXFLAGS) > +KBUILD_HOSTCXXFLAGS := -Wall -O2 $(HOST_LFS_CFLAGS) $(HOSTCXXFLAGS) > KBUILD_HOSTLDFLAGS := $(HOST_LFS_LDFLAGS) $(HOSTLDFLAGS) > KBUILD_HOSTLDLIBS := $(HOST_LFS_LIBS) $(HOSTLDLIBS) > > diff --git a/scripts/gcc-plugins/Makefile b/scripts/gcc-plugins/Makefile > index f2ee8bd7abc6..efff00959a9c 100644 > --- a/scripts/gcc-plugins/Makefile > +++ b/scripts/gcc-plugins/Makefile > @@ -10,7 +10,7 @@ else > HOSTLIBS := hostcxxlibs > HOST_EXTRACXXFLAGS += -I$(GCC_PLUGINS_DIR)/include -I$(src) -std=gnu++98 -fno-rtti > HOST_EXTRACXXFLAGS += -fno-exceptions -fasynchronous-unwind-tables -ggdb > - HOST_EXTRACXXFLAGS += -Wno-narrowing -Wno-unused-variable > + HOST_EXTRACXXFLAGS += -Wno-narrowing -Wno-unused-variable -Wno-c++11-compat > export HOST_EXTRACXXFLAGS > endif > > -- > 2.17.1 >
On Thu, Mar 26, 2020 at 11:06 AM Kees Cook <keescook@chromium.org> wrote: > > On Wed, Mar 25, 2020 at 12:14:32PM +0900, Masahiro Yamada wrote: > > Add -Wall to catch more warnings for C++ host programs. > > > > When I submitted the previous version, the 0-day bot reported > > -Wc++11-compat warnings for old GCC: > > > > HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o > > In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:28:0, > > from scripts/gcc-plugins/gcc-common.h:15, > > from scripts/gcc-plugins/latent_entropy_plugin.c:78: > > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:102:21: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > > fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ > > ^ > > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:170:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > > fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ > > ^ > > In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:42:0, > > from scripts/gcc-plugins/gcc-common.h:15, > > from scripts/gcc-plugins/latent_entropy_plugin.c:78: > > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/defaults.h:126:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > > fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ > > ^ > > > > The source of the warnings is in the plugin headers, so we have no > > control of it. I just suppressed them by adding -Wno-c++11-compat to > > scripts/gcc-plugins/Makefile. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > Acked-by: Kees Cook <keescook@chromium.org> > > -Kees Applied to linux-kbuild.
diff --git a/Makefile b/Makefile index 3b57ccab367b..593d8f1bbe90 100644 --- a/Makefile +++ b/Makefile @@ -400,7 +400,7 @@ HOSTCXX = g++ KBUILD_HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \ -fomit-frame-pointer -std=gnu89 $(HOST_LFS_CFLAGS) \ $(HOSTCFLAGS) -KBUILD_HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS) $(HOSTCXXFLAGS) +KBUILD_HOSTCXXFLAGS := -Wall -O2 $(HOST_LFS_CFLAGS) $(HOSTCXXFLAGS) KBUILD_HOSTLDFLAGS := $(HOST_LFS_LDFLAGS) $(HOSTLDFLAGS) KBUILD_HOSTLDLIBS := $(HOST_LFS_LIBS) $(HOSTLDLIBS) diff --git a/scripts/gcc-plugins/Makefile b/scripts/gcc-plugins/Makefile index f2ee8bd7abc6..efff00959a9c 100644 --- a/scripts/gcc-plugins/Makefile +++ b/scripts/gcc-plugins/Makefile @@ -10,7 +10,7 @@ else HOSTLIBS := hostcxxlibs HOST_EXTRACXXFLAGS += -I$(GCC_PLUGINS_DIR)/include -I$(src) -std=gnu++98 -fno-rtti HOST_EXTRACXXFLAGS += -fno-exceptions -fasynchronous-unwind-tables -ggdb - HOST_EXTRACXXFLAGS += -Wno-narrowing -Wno-unused-variable + HOST_EXTRACXXFLAGS += -Wno-narrowing -Wno-unused-variable -Wno-c++11-compat export HOST_EXTRACXXFLAGS endif
Add -Wall to catch more warnings for C++ host programs. When I submitted the previous version, the 0-day bot reported -Wc++11-compat warnings for old GCC: HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:28:0, from scripts/gcc-plugins/gcc-common.h:15, from scripts/gcc-plugins/latent_entropy_plugin.c:78: /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:102:21: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ ^ /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:170:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:42:0, from scripts/gcc-plugins/gcc-common.h:15, from scripts/gcc-plugins/latent_entropy_plugin.c:78: /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/defaults.h:126:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ The source of the warnings is in the plugin headers, so we have no control of it. I just suppressed them by adding -Wno-c++11-compat to scripts/gcc-plugins/Makefile. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- Makefile | 2 +- scripts/gcc-plugins/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)