diff mbox series

[v2,1/2] i3c: master: svc: fix compatibility string mismatch with binding doc

Message ID 20231017194657.3199749-1-Frank.Li@nxp.com (mailing list archive)
State Superseded
Headers show
Series [v2,1/2] i3c: master: svc: fix compatibility string mismatch with binding doc | expand

Commit Message

Frank Li Oct. 17, 2023, 7:46 p.m. UTC 
In the binding documentation, the compatible string is specified as
'silvaco,i3c-master-v1', but in the driver, it is defined as
'silvaco,i3c-master'.

Rename 'silvaco,i3c-master' to 'silvaco,i3c-master-v1' to ensure
compatibility with the documentation.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v2 to v3
    - Miquèl think drop silvaco,i3c-master totally. I grep dts tree. No
    upstream dts use silvaco,i3c-master yet.
      I have not add "Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>",
    it is different solution with previous one even just one line change.
      I think v2/v3 both is good, feel free to pick each one.
    
    Change from v1 to v2
    - update driver by using compatible string silvaco,i3c-master-v1
    
    Change from v1 to v2
    - update driver by using compatible string silvaco,i3c-master-v1

 drivers/i3c/master/svc-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexandre Belloni Nov. 3, 2023, 7:04 p.m. UTC | #1 
On Tue, 17 Oct 2023 15:46:56 -0400, Frank Li wrote:
> In the binding documentation, the compatible string is specified as
> 'silvaco,i3c-master-v1', but in the driver, it is defined as
> 'silvaco,i3c-master'.
> 
> Rename 'silvaco,i3c-master' to 'silvaco,i3c-master-v1' to ensure
> compatibility with the documentation.
> 
> [...]

Applied, thanks!

[1/2] i3c: master: svc: fix compatibility string mismatch with binding doc
      commit: 8911eae9c8a947e5c1cc4fcce40473f1f5e475cd

Best regards,
diff mbox series

Patch

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index cf932ee056ef9..e307ba2b965e6 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1650,7 +1650,7 @@  static const struct dev_pm_ops svc_i3c_pm_ops = {
 };
 
 static const struct of_device_id svc_i3c_master_of_match_tbl[] = {
-	{ .compatible = "silvaco,i3c-master" },
+	{ .compatible = "silvaco,i3c-master-v1"},
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl);