mbox series

[v2,0/7] bme680 cleanup

Message ID 20180815203835.21079-1-dpfrey@gmail.com (mailing list archive)
Headers show
Series bme680 cleanup | expand

Message

David Frey Aug. 15, 2018, 8:38 p.m. UTC
Note that I don't currently have bme680 hardware available, so I am hoping that
Himanshu is willing to validate the changes.

v2:
  This version addresses Himanshu's feedback
  - split v1 patch 1 into 6 commits
  - substantially changed "simplify oversampling handling" after review
    identified a bug in the previous patch version and I spent some more time
    thinking about the problem

v1:
  I have performed some minor cleanup on the bme680 driver. I don't think
  there's anything controversial in my changes. Let me know what you think

David Frey (7):
  iio: chemical: bme680: use clamp macro
  iio: chemical: bme680: cleanup bme680_read_calib formatting
  iio: chemical: bme680: indent #defines consistently
  iio: chemical: bme680: change MSK->MASK in #defines
  iio: chemical: bme680: use GENMASK macro
  iio: chemical: bme680: use FIELD_GET macro
  iio: chemical: bme680: simplify oversampling handling

 drivers/iio/chemical/bme680.h      |  17 +++--
 drivers/iio/chemical/bme680_core.c | 144 +++++++++++++------------------------
 2 files changed, 59 insertions(+), 102 deletions(-)

Comments

Himanshu Jha Aug. 16, 2018, 6:24 a.m. UTC | #1
On Wed, Aug 15, 2018 at 01:38:28PM -0700, David Frey wrote:
> Note that I don't currently have bme680 hardware available, so I am hoping that
> Himanshu is willing to validate the changes.

Another thing that is screwed up is Jonathan's email ;)

It is jic23@kernel.org and not jic23@vger.kernel.org

You can use:

$ ./scripts/get_maintainer.pl <patch>

Thanks
David Frey Aug. 16, 2018, 12:55 p.m. UTC | #2
On 8/15/2018 11:24 PM, Himanshu Jha wrote:
> On Wed, Aug 15, 2018 at 01:38:28PM -0700, David Frey wrote:
>> Note that I don't currently have bme680 hardware available, so I am hoping that
>> Himanshu is willing to validate the changes.
> 
> Another thing that is screwed up is Jonathan's email ;)
> 
> It is jic23@kernel.org and not jic23@vger.kernel.org
> 
> You can use:
> 
> $ ./scripts/get_maintainer.pl <patch>

Yes... I realized that shortly after I received 8 bounce e-mails in reply.