| Message ID | 20220220175149.503495-1-jic23@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: gyro: mpu3050: Cleanup exports and PM | expand |
On Sun, 20 Feb 2022 17:51:47 +0000 Jonathan Cameron <jic23@kernel.org> wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Paul Cercueil happened to chose this driver as his example for > EXPORT_RUNTIME_DEV_PM_OPS() in his recent patch set to cleanup > how we handle dev_pm_ops. > > https://lore.kernel.org/linux-pm/20220105101106.00005ae0@Huawei.com/ > > Whilst reviewing that I noticed that there were a bunch of exports > in this driver that are only used by other files compiled into the same > module. Paul found another driver to demo his new infrastructure. > > This series is cleaning up that oddity by first dropping the exports > and then using the new pm_ptr() and DEFINE_RUNTIME_PM_DEV_OPS() to allow > the compiler to be responsible for removing the unused code for us rather > than requiring manual CONFIG_PM guards. > Oops. Lost my own series down the back of the sofa. No idea why I didn't apply these when Linus reviewed them back in March. Anyhow, now applied to the togreg branch of iio.git (with some fuzz) and pushed out as testing to see if 0-day is happy with them. Thanks, Jonathan > Jonathan Cameron (2): > iio: gyro: mpu3050: Drop unused symbol exports. > iio: gyro: mpu3050: Use pm_ptr() and DEFINE_RUNTIME_DEV_PM_OPS() > > drivers/iio/gyro/mpu3050-core.c | 14 ++------------ > drivers/iio/gyro/mpu3050-i2c.c | 2 +- > 2 files changed, 3 insertions(+), 13 deletions(-) >
From: Jonathan Cameron <Jonathan.Cameron@huawei.com> Paul Cercueil happened to chose this driver as his example for EXPORT_RUNTIME_DEV_PM_OPS() in his recent patch set to cleanup how we handle dev_pm_ops. https://lore.kernel.org/linux-pm/20220105101106.00005ae0@Huawei.com/ Whilst reviewing that I noticed that there were a bunch of exports in this driver that are only used by other files compiled into the same module. Paul found another driver to demo his new infrastructure. This series is cleaning up that oddity by first dropping the exports and then using the new pm_ptr() and DEFINE_RUNTIME_PM_DEV_OPS() to allow the compiler to be responsible for removing the unused code for us rather than requiring manual CONFIG_PM guards. Jonathan Cameron (2): iio: gyro: mpu3050: Drop unused symbol exports. iio: gyro: mpu3050: Use pm_ptr() and DEFINE_RUNTIME_DEV_PM_OPS() drivers/iio/gyro/mpu3050-core.c | 14 ++------------ drivers/iio/gyro/mpu3050-i2c.c | 2 +- 2 files changed, 3 insertions(+), 13 deletions(-)