diff mbox series

[20/20] iio: adc: rockchip: correct alignment of timestamp

Message ID	20241215182912.481706-21-jic23@kernel.org (mailing list archive)
State	New
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CF341B5ECB for <linux-iio@vger.kernel.org>; Sun, 15 Dec 2024 18:30:24 +0000 (UTC) From: Jonathan Cameron <jic23@kernel.org> To: linux-iio@vger.kernel.org, Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: David Lechner <dlechner@baylibre.com>, Heiko Stuebner <heiko@sntech.de>, Jonathan Cameron <Jonathan.Cameron@huawei.com> Subject: [PATCH 20/20] iio: adc: rockchip: correct alignment of timestamp Date: Sun, 15 Dec 2024 18:29:11 +0000 Message-ID: <20241215182912.481706-21-jic23@kernel.org> In-Reply-To: <20241215182912.481706-1-jic23@kernel.org> References: <20241215182912.481706-1-jic23@kernel.org> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	IIO: Tidying up timestamp alignment markings. \| expand [00/20] IIO: Tidying up timestamp alignment markings. [01/20] iio: adc: ad7944: Fix sign and use aligned_s64 for timestamp. [02/20] io: adc: ina2xx-adc: Fix sign and use aligned_s64 for timestamp. [03/20] iio: temperature: tmp006: Use aligned_s64 instead of open coding alignment. [04/20] iio: resolver: ad2s1210: Use aligned_s64 instead of open coding alignment. [05/20] iio: proximity: Use aligned_s64 instead of open coding alignment. [06/20] iio: pressure: Use aligned_s64 instead of open coding alignment. [07/20] iio: magnetometer: Use aligned_s64 instead of open coding alignment. [08/20] iio: light: Use aligned_s64 instead of open coding alignment. [09/20] iio: imu: Use aligned_s64 instead of open coding alignment. [10/20] iio: humidity: Use aligned_s64 instead of open coding alignment. [11/20] iio: gyro: Use aligned_s64 instead of open coding alignment. [12/20] iio: chemical: Use aligned_s64 instead of open coding alignment. [13/20] iio: adc: Use aligned_s64 instead of open coding alignment. [14/20] iio: accel: bma220: Use aligned_s64 instead of open coding alignment. [15/20] iio: buffer: Make timestamp s64 in iio_push_to_buffers_with_timestamp() [16/20] iio: adc: ti-lmp92064: Switch timestamp type from int64_t __aligned(8) to aligned_s64 [17/20] iio: chemical: scd4x: switch timestamp type from int64_t __aligned(8) to aligned_s64 [18/20] iio: imu: inv_icm42600: switch timestamp type from int64_t __aligned(8) to aligned_s64 [19/20] iio: adc: mt6360: Correct marking of timestamp alignment. [20/20] iio: adc: rockchip: correct alignment of timestamp

Commit Message

Jonathan Cameron Dec. 15, 2024, 6:29 p.m. UTC

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

I assume this device is only used on architectures where a 8 byte
integer type is always 8 byte aligned.  However, I would prefer IIO
drivers to never make that assumption as the code gets copied into
new drivers which are not so tightly couple to one driver and those
can run on architectures that align these types to only 4 bytes in which
case this structure may be 4 byte to small leading to a buffer overrun.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/adc/rockchip_saradc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
index 240cfa391674..bf4340094031 100644
--- a/drivers/iio/adc/rockchip_saradc.c
+++ b/drivers/iio/adc/rockchip_saradc.c
@@ -363,7 +363,7 @@  static irqreturn_t rockchip_saradc_trigger_handler(int irq, void *p)
 	 */
 	struct {
 		u16 values[SARADC_MAX_CHANNELS];
-		int64_t timestamp;
+		aligned_s64 timestamp;
 	} data;
 	int ret;
 	int i, j = 0;