| Message ID | 1431726191-11466-4-git-send-email-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, May 15, 2015 at 06:43:11PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject > bogus threaded irq requests") threaded IRQs without a primary handler > need to be requested with IRQF_ONESHOT, otherwise the request will fail. > > So pass the IRQF_ONESHOT flag in this case. > > The semantic patch that makes this change is available > in scripts/coccinelle/misc/irqf_oneshot.cocci. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Applied all 4, thank you. > --- > drivers/input/misc/wm831x-on.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/misc/wm831x-on.c b/drivers/input/misc/wm831x-on.c > index 59d4f7b..1b44de2 100644 > --- a/drivers/input/misc/wm831x-on.c > +++ b/drivers/input/misc/wm831x-on.c > @@ -99,7 +99,8 @@ static int wm831x_on_probe(struct platform_device *pdev) > wm831x_on->dev->dev.parent = &pdev->dev; > > ret = request_threaded_irq(irq, NULL, wm831x_on_irq, > - IRQF_TRIGGER_RISING, "wm831x_on", > + IRQF_TRIGGER_RISING | IRQF_ONESHOT, > + "wm831x_on", > wm831x_on); > if (ret < 0) { > dev_err(&pdev->dev, "Unable to request IRQ: %d\n", ret); > -- > 1.9.1 >
diff --git a/drivers/input/misc/wm831x-on.c b/drivers/input/misc/wm831x-on.c index 59d4f7b..1b44de2 100644 --- a/drivers/input/misc/wm831x-on.c +++ b/drivers/input/misc/wm831x-on.c @@ -99,7 +99,8 @@ static int wm831x_on_probe(struct platform_device *pdev) wm831x_on->dev->dev.parent = &pdev->dev; ret = request_threaded_irq(irq, NULL, wm831x_on_irq, - IRQF_TRIGGER_RISING, "wm831x_on", + IRQF_TRIGGER_RISING | IRQF_ONESHOT, + "wm831x_on", wm831x_on); if (ret < 0) { dev_err(&pdev->dev, "Unable to request IRQ: %d\n", ret);