| Message ID | 20230424123522.18302-28-nikita.shubin@maquefel.me (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ep93xx device tree conversion | expand |
On Mon, Apr 24, 2023 at 03:34:43PM +0300, Nikita Shubin wrote: > - get keymap from the device tree > - find register range from the device tree > - get interrupts from device tree Note, the below comments may be applied to the whole series where it makes sense. ... > +#include <linux/of.h> > +#include <linux/of_platform.h> Why? You do not use them. Please, check all your patches to follow the rule: include only the headers you are really using (or their up level wrappers if required). (Hint: in this case you have to include mod_devicetable.h) ... > +static const struct of_device_id ep93xx_keypad_of_ids[] = { > + { .compatible = "cirrus,ep9301-keypad" }, > + {}, No comma for the terminator entry. > +};
diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c index 55075addcac2..bf77754fa4c7 100644 --- a/drivers/input/keyboard/ep93xx_keypad.c +++ b/drivers/input/keyboard/ep93xx_keypad.c @@ -20,6 +20,8 @@ #include <linux/bits.h> #include <linux/module.h> #include <linux/platform_device.h> +#include <linux/of.h> +#include <linux/of_platform.h> #include <linux/interrupt.h> #include <linux/clk.h> #include <linux/io.h> @@ -315,10 +317,17 @@ static int ep93xx_keypad_remove(struct platform_device *pdev) return 0; } +static const struct of_device_id ep93xx_keypad_of_ids[] = { + { .compatible = "cirrus,ep9301-keypad" }, + {}, +}; +MODULE_DEVICE_TABLE(of, ep93xx_keypad_of_ids); + static struct platform_driver ep93xx_keypad_driver = { .driver = { .name = "ep93xx-keypad", .pm = pm_sleep_ptr(&ep93xx_keypad_pm_ops), + .of_match_table = ep93xx_keypad_of_ids, }, .probe = ep93xx_keypad_probe, .remove = ep93xx_keypad_remove,
- get keymap from the device tree - find register range from the device tree - get interrupts from device tree Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> --- Notes: Arnd Bergmann: - wildcards ep93xx to something meaningful, i.e. ep9301 - drop wrappers drivers/input/keyboard/ep93xx_keypad.c | 9 +++++++++ 1 file changed, 9 insertions(+)