| Message ID | 5541E9F1.5090902@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Hans Sorry for the delay. I'm afraid I haven't built a kernel before, so I need some help. I've found this link I think describes what I have to do https://www.kernel.org/doc/Documentation/applying-patches.txt I suppose it's right. I've installed kernel 4.0.0-040000rc6.201503291935. So I suppose I have to download sources for this kernel. Once downloaded, I have to change to the kernel source dir and run: $ patch -p1 < ../0001-elantech-Fix-detection-of-touchpads-where-the-revisi.patch Is all that right? If yes, should I compile this patched kernel? How can I do it? Thanks in advance. David Zafra El 30/04/15 a las 10:38, Hans de Goede escribió: > Hi, > > On 30-04-15 07:34, David Zafra Gómez wrote: >> Hi everyone >> >> El 29/04/15 a las 09:35, Hans de Goede escribió: >>> Hi, >>> >>> On 28-04-15 23:26, David Zafra Gómez wrote: >>>> [ 0.257439] pnp 00:06: Plug and Play ACPI device, IDs ETD0108 >>>> SYN0a00 SYN0002 PNP0f03 PNP0f13 PNP0f12 (active) >>> >>> Ok, so the "ETD0108" here means that you have an elantech ps/2 >>> touchpad. >> Great! You got it. >>> >>> This also stands out in the log: >>> >>> > [ 0.958323] i8042: [49] MUX error, status is 75, data is fe >>> >>> So the first thing to try is to boot with i8042.nomux=1 on the kernel >>> commandline. >> I have done it. The touchpad issue hasn't been solved. Do you want me >> to send dmesg output? > > I've taken another look at the traces you've posted before and I think > that > I've found the problem. Can you build a kernel with the attached patch > and let us know if that fixes things ? > > Regards, > > Hans > > > ----- > No se encontraron virus en este mensaje. > Comprobado por AVG -www.avg.com > Versión: 2015.0.5863 / Base de datos de virus: 4339/9659 - Fecha de publicación: 04/29/15 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 06-05-15 22:21, David Zafra Gómez wrote: > Hi Hans > > Sorry for the delay. > > I'm afraid I haven't built a kernel before, so I need some help. > > I've found this link I think describes what I have to do > https://www.kernel.org/doc/Documentation/applying-patches.txt > I suppose it's right. > > I've installed kernel 4.0.0-040000rc6.201503291935. So I suppose I have to > download sources for this kernel. > > Once downloaded, I have to change to the kernel source dir and run: > $ patch -p1 < ../0001-elantech-Fix-detection-of-touchpads-where-the-revisi.patch > > Is all that right? Yes that is correct. > If yes, should I compile this patched kernel? How can I do it? Usually your distro will have a wikipage with instructions on how to build your own kernel, and it is best to follow your distros instructions. If you're using Fedora I can build a test kernel for you to install. Regards, Hans > > Thanks in advance. > > David Zafra > > El 30/04/15 a las 10:38, Hans de Goede escribió: >> Hi, >> >> On 30-04-15 07:34, David Zafra Gómez wrote: >>> Hi everyone >>> >>> El 29/04/15 a las 09:35, Hans de Goede escribió: >>>> Hi, >>>> >>>> On 28-04-15 23:26, David Zafra Gómez wrote: >>>>> [ 0.257439] pnp 00:06: Plug and Play ACPI device, IDs ETD0108 >>>>> SYN0a00 SYN0002 PNP0f03 PNP0f13 PNP0f12 (active) >>>> >>>> Ok, so the "ETD0108" here means that you have an elantech ps/2 touchpad. >>> Great! You got it. >>>> >>>> This also stands out in the log: >>>> >>>> > [ 0.958323] i8042: [49] MUX error, status is 75, data is fe >>>> >>>> So the first thing to try is to boot with i8042.nomux=1 on the kernel >>>> commandline. >>> I have done it. The touchpad issue hasn't been solved. Do you want me to send >>> dmesg output? >> >> I've taken another look at the traces you've posted before and I think that >> I've found the problem. Can you build a kernel with the attached patch >> and let us know if that fixes things ? >> >> Regards, >> >> Hans >> >> >> ----- >> No se encontraron virus en este mensaje. >> Comprobado por AVG -www.avg.com >> Versión: 2015.0.5863 / Base de datos de virus: 4339/9659 - Fecha de publicación: 04/29/15 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
It worked like a charm!! Ubuntu support team helped me to build the patched kernel. Now I can use all advanced touchpad features. Thank you very much to Hans and Benjamin!! El 18/05/15 a las 12:19, Hans de Goede escribió: > Hi, > > On 06-05-15 22:21, David Zafra Gómez wrote: >> Hi Hans >> >> Sorry for the delay. >> >> I'm afraid I haven't built a kernel before, so I need some help. >> >> I've found this link I think describes what I have to do >> https://www.kernel.org/doc/Documentation/applying-patches.txt >> I suppose it's right. >> >> I've installed kernel 4.0.0-040000rc6.201503291935. So I suppose I >> have to >> download sources for this kernel. >> >> Once downloaded, I have to change to the kernel source dir and run: >> $ patch -p1 < >> ../0001-elantech-Fix-detection-of-touchpads-where-the-revisi.patch >> >> Is all that right? > > Yes that is correct. > >> If yes, should I compile this patched kernel? How can I do it? > > Usually your distro will have a wikipage with instructions on how to > build > your own kernel, and it is best to follow your distros instructions. > > If you're using Fedora I can build a test kernel for you to install. > > Regards, > > Hans > > >> >> Thanks in advance. >> >> David Zafra >> >> El 30/04/15 a las 10:38, Hans de Goede escribió: >>> Hi, >>> >>> On 30-04-15 07:34, David Zafra Gómez wrote: >>>> Hi everyone >>>> >>>> El 29/04/15 a las 09:35, Hans de Goede escribió: >>>>> Hi, >>>>> >>>>> On 28-04-15 23:26, David Zafra Gómez wrote: >>>>>> [ 0.257439] pnp 00:06: Plug and Play ACPI device, IDs ETD0108 >>>>>> SYN0a00 SYN0002 PNP0f03 PNP0f13 PNP0f12 (active) >>>>> >>>>> Ok, so the "ETD0108" here means that you have an elantech ps/2 >>>>> touchpad. >>>> Great! You got it. >>>>> >>>>> This also stands out in the log: >>>>> >>>>> > [ 0.958323] i8042: [49] MUX error, status is 75, data is fe >>>>> >>>>> So the first thing to try is to boot with i8042.nomux=1 on the kernel >>>>> commandline. >>>> I have done it. The touchpad issue hasn't been solved. Do you want >>>> me to send >>>> dmesg output? >>> >>> I've taken another look at the traces you've posted before and I >>> think that >>> I've found the problem. Can you build a kernel with the attached patch >>> and let us know if that fixes things ? >>> >>> Regards, >>> >>> Hans >>> >>> >>> ----- >>> No se encontraron virus en este mensaje. >>> Comprobado por AVG -www.avg.com >>> Versión: 2015.0.5863 / Base de datos de virus: 4339/9659 - Fecha de >>> publicación: 04/29/15 >> > > > ----- > No se encontraron virus en este mensaje. > Comprobado por AVG - www.avg.com > Versión: 2015.0.5941 / Base de datos de virus: 4347/9819 - Fecha de > publicación: 05/19/15 > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 27-05-15 22:35, David Zafra Gómez wrote: > It worked like a charm!! > > Ubuntu support team helped me to build the patched kernel. Now I can use all advanced touchpad features. > > Thank you very much to Hans and Benjamin!! Thanks for testing the patch, now that it has been tested I've submitted it for inclusion into the upstream kernel. Regards, Hans > > El 18/05/15 a las 12:19, Hans de Goede escribió: >> Hi, >> >> On 06-05-15 22:21, David Zafra Gómez wrote: >>> Hi Hans >>> >>> Sorry for the delay. >>> >>> I'm afraid I haven't built a kernel before, so I need some help. >>> >>> I've found this link I think describes what I have to do >>> https://www.kernel.org/doc/Documentation/applying-patches.txt >>> I suppose it's right. >>> >>> I've installed kernel 4.0.0-040000rc6.201503291935. So I suppose I have to >>> download sources for this kernel. >>> >>> Once downloaded, I have to change to the kernel source dir and run: >>> $ patch -p1 < ../0001-elantech-Fix-detection-of-touchpads-where-the-revisi.patch >>> >>> Is all that right? >> >> Yes that is correct. >> >>> If yes, should I compile this patched kernel? How can I do it? >> >> Usually your distro will have a wikipage with instructions on how to build >> your own kernel, and it is best to follow your distros instructions. >> >> If you're using Fedora I can build a test kernel for you to install. >> >> Regards, >> >> Hans >> >> >>> >>> Thanks in advance. >>> >>> David Zafra >>> >>> El 30/04/15 a las 10:38, Hans de Goede escribió: >>>> Hi, >>>> >>>> On 30-04-15 07:34, David Zafra Gómez wrote: >>>>> Hi everyone >>>>> >>>>> El 29/04/15 a las 09:35, Hans de Goede escribió: >>>>>> Hi, >>>>>> >>>>>> On 28-04-15 23:26, David Zafra Gómez wrote: >>>>>>> [ 0.257439] pnp 00:06: Plug and Play ACPI device, IDs ETD0108 >>>>>>> SYN0a00 SYN0002 PNP0f03 PNP0f13 PNP0f12 (active) >>>>>> >>>>>> Ok, so the "ETD0108" here means that you have an elantech ps/2 touchpad. >>>>> Great! You got it. >>>>>> >>>>>> This also stands out in the log: >>>>>> >>>>>> > [ 0.958323] i8042: [49] MUX error, status is 75, data is fe >>>>>> >>>>>> So the first thing to try is to boot with i8042.nomux=1 on the kernel >>>>>> commandline. >>>>> I have done it. The touchpad issue hasn't been solved. Do you want me to send >>>>> dmesg output? >>>> >>>> I've taken another look at the traces you've posted before and I think that >>>> I've found the problem. Can you build a kernel with the attached patch >>>> and let us know if that fixes things ? >>>> >>>> Regards, >>>> >>>> Hans >>>> >>>> >>>> ----- >>>> No se encontraron virus en este mensaje. >>>> Comprobado por AVG -www.avg.com >>>> Versión: 2015.0.5863 / Base de datos de virus: 4339/9659 - Fecha de publicación: 04/29/15 >>> >> >> >> ----- >> No se encontraron virus en este mensaje. >> Comprobado por AVG - www.avg.com >> Versión: 2015.0.5941 / Base de datos de virus: 4347/9819 - Fecha de publicación: 05/19/15 >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
OK Hans. Could you please tell me what kernel version will this patch be included in? Regards, David El 28/05/2015 a las 11:10, Hans de Goede escribió: > Hi, > > On 27-05-15 22:35, David Zafra Gómez wrote: >> It worked like a charm!! >> >> Ubuntu support team helped me to build the patched kernel. Now I can >> use all advanced touchpad features. >> >> Thank you very much to Hans and Benjamin!! > > Thanks for testing the patch, now that it has been tested I've > submitted it for inclusion into the upstream kernel. > > Regards, > > Hans > > >> >> El 18/05/15 a las 12:19, Hans de Goede escribió: >>> Hi, >>> >>> On 06-05-15 22:21, David Zafra Gómez wrote: >>>> Hi Hans >>>> >>>> Sorry for the delay. >>>> >>>> I'm afraid I haven't built a kernel before, so I need some help. >>>> >>>> I've found this link I think describes what I have to do >>>> https://www.kernel.org/doc/Documentation/applying-patches.txt >>>> I suppose it's right. >>>> >>>> I've installed kernel 4.0.0-040000rc6.201503291935. So I suppose I >>>> have to >>>> download sources for this kernel. >>>> >>>> Once downloaded, I have to change to the kernel source dir and run: >>>> $ patch -p1 < >>>> ../0001-elantech-Fix-detection-of-touchpads-where-the-revisi.patch >>>> >>>> Is all that right? >>> >>> Yes that is correct. >>> >>>> If yes, should I compile this patched kernel? How can I do it? >>> >>> Usually your distro will have a wikipage with instructions on how to >>> build >>> your own kernel, and it is best to follow your distros instructions. >>> >>> If you're using Fedora I can build a test kernel for you to install. >>> >>> Regards, >>> >>> Hans >>> >>> >>>> >>>> Thanks in advance. >>>> >>>> David Zafra >>>> >>>> El 30/04/15 a las 10:38, Hans de Goede escribió: >>>>> Hi, >>>>> >>>>> On 30-04-15 07:34, David Zafra Gómez wrote: >>>>>> Hi everyone >>>>>> >>>>>> El 29/04/15 a las 09:35, Hans de Goede escribió: >>>>>>> Hi, >>>>>>> >>>>>>> On 28-04-15 23:26, David Zafra Gómez wrote: >>>>>>>> [ 0.257439] pnp 00:06: Plug and Play ACPI device, IDs ETD0108 >>>>>>>> SYN0a00 SYN0002 PNP0f03 PNP0f13 PNP0f12 (active) >>>>>>> >>>>>>> Ok, so the "ETD0108" here means that you have an elantech ps/2 >>>>>>> touchpad. >>>>>> Great! You got it. >>>>>>> >>>>>>> This also stands out in the log: >>>>>>> >>>>>>> > [ 0.958323] i8042: [49] MUX error, status is 75, data is fe >>>>>>> >>>>>>> So the first thing to try is to boot with i8042.nomux=1 on the >>>>>>> kernel >>>>>>> commandline. >>>>>> I have done it. The touchpad issue hasn't been solved. Do you >>>>>> want me to send >>>>>> dmesg output? >>>>> >>>>> I've taken another look at the traces you've posted before and I >>>>> think that >>>>> I've found the problem. Can you build a kernel with the attached >>>>> patch >>>>> and let us know if that fixes things ? >>>>> >>>>> Regards, >>>>> >>>>> Hans >>>>> >>>>> >>>>> ----- >>>>> No se encontraron virus en este mensaje. >>>>> Comprobado por AVG -www.avg.com >>>>> Versión: 2015.0.5863 / Base de datos de virus: 4339/9659 - Fecha >>>>> de publicación: 04/29/15 >>>> >>> >>> >>> ----- >>> No se encontraron virus en este mensaje. >>> Comprobado por AVG - www.avg.com >>> Versión: 2015.0.5941 / Base de datos de virus: 4347/9819 - Fecha de >>> publicación: 05/19/15 >>> >>> >> > > > ----- > No se encontraron virus en este mensaje. > Comprobado por AVG - www.avg.com > Versión: 2015.0.5961 / Base de datos de virus: 4354/9886 - Fecha de > publicación: 05/28/15 > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 28-05-15 16:55, David Zafra Gómez wrote: > OK Hans. > > Could you please tell me what kernel version will this patch be included in? That is hard to predict, I would expect it to make 4.3 for certain, hopefully also 4.2 and a 4.1.x bugfix release. Regards, Hans > > Regards, > > David > > El 28/05/2015 a las 11:10, Hans de Goede escribió: >> Hi, >> >> On 27-05-15 22:35, David Zafra Gómez wrote: >>> It worked like a charm!! >>> >>> Ubuntu support team helped me to build the patched kernel. Now I can use all advanced touchpad features. >>> >>> Thank you very much to Hans and Benjamin!! >> >> Thanks for testing the patch, now that it has been tested I've >> submitted it for inclusion into the upstream kernel. >> >> Regards, >> >> Hans >> >> >>> >>> El 18/05/15 a las 12:19, Hans de Goede escribió: >>>> Hi, >>>> >>>> On 06-05-15 22:21, David Zafra Gómez wrote: >>>>> Hi Hans >>>>> >>>>> Sorry for the delay. >>>>> >>>>> I'm afraid I haven't built a kernel before, so I need some help. >>>>> >>>>> I've found this link I think describes what I have to do >>>>> https://www.kernel.org/doc/Documentation/applying-patches.txt >>>>> I suppose it's right. >>>>> >>>>> I've installed kernel 4.0.0-040000rc6.201503291935. So I suppose I have to >>>>> download sources for this kernel. >>>>> >>>>> Once downloaded, I have to change to the kernel source dir and run: >>>>> $ patch -p1 < ../0001-elantech-Fix-detection-of-touchpads-where-the-revisi.patch >>>>> >>>>> Is all that right? >>>> >>>> Yes that is correct. >>>> >>>>> If yes, should I compile this patched kernel? How can I do it? >>>> >>>> Usually your distro will have a wikipage with instructions on how to build >>>> your own kernel, and it is best to follow your distros instructions. >>>> >>>> If you're using Fedora I can build a test kernel for you to install. >>>> >>>> Regards, >>>> >>>> Hans >>>> >>>> >>>>> >>>>> Thanks in advance. >>>>> >>>>> David Zafra >>>>> >>>>> El 30/04/15 a las 10:38, Hans de Goede escribió: >>>>>> Hi, >>>>>> >>>>>> On 30-04-15 07:34, David Zafra Gómez wrote: >>>>>>> Hi everyone >>>>>>> >>>>>>> El 29/04/15 a las 09:35, Hans de Goede escribió: >>>>>>>> Hi, >>>>>>>> >>>>>>>> On 28-04-15 23:26, David Zafra Gómez wrote: >>>>>>>>> [ 0.257439] pnp 00:06: Plug and Play ACPI device, IDs ETD0108 >>>>>>>>> SYN0a00 SYN0002 PNP0f03 PNP0f13 PNP0f12 (active) >>>>>>>> >>>>>>>> Ok, so the "ETD0108" here means that you have an elantech ps/2 touchpad. >>>>>>> Great! You got it. >>>>>>>> >>>>>>>> This also stands out in the log: >>>>>>>> >>>>>>>> > [ 0.958323] i8042: [49] MUX error, status is 75, data is fe >>>>>>>> >>>>>>>> So the first thing to try is to boot with i8042.nomux=1 on the kernel >>>>>>>> commandline. >>>>>>> I have done it. The touchpad issue hasn't been solved. Do you want me to send >>>>>>> dmesg output? >>>>>> >>>>>> I've taken another look at the traces you've posted before and I think that >>>>>> I've found the problem. Can you build a kernel with the attached patch >>>>>> and let us know if that fixes things ? >>>>>> >>>>>> Regards, >>>>>> >>>>>> Hans >>>>>> >>>>>> >>>>>> ----- >>>>>> No se encontraron virus en este mensaje. >>>>>> Comprobado por AVG -www.avg.com >>>>>> Versión: 2015.0.5863 / Base de datos de virus: 4339/9659 - Fecha de publicación: 04/29/15 >>>>> >>>> >>>> >>>> ----- >>>> No se encontraron virus en este mensaje. >>>> Comprobado por AVG - www.avg.com >>>> Versión: 2015.0.5941 / Base de datos de virus: 4347/9819 - Fecha de publicación: 05/19/15 >>>> >>>> >>> >> >> >> ----- >> No se encontraron virus en este mensaje. >> Comprobado por AVG - www.avg.com >> Versión: 2015.0.5961 / Base de datos de virus: 4354/9886 - Fecha de publicación: 05/28/15 >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From 0b0bf8fd125b0925166470cf8cf9f7b2f310efd4 Mon Sep 17 00:00:00 2001 From: Hans de Goede <hdegoede@redhat.com> Date: Thu, 30 Apr 2015 10:29:38 +0200 Subject: [PATCH] elantech: Fix detection of touchpads where the revision matches a known rate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Make the check to skip the rate check more lax, so that it applies to all hw_version 4 models. This fixes the touchpad not being detected properly on Asus PU551LA laptops. Reported-and-tested-by: David Zafra Gómez <dezeta@klo.es> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/input/mouse/elantech.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 991dc6b..e30286f 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c @@ -1379,7 +1379,8 @@ static bool elantech_is_signature_valid(const unsigned char *param) * Some models have a revision higher then 20. Meaning param[2] may * be 10 or 20, skip the rates check for these. */ - if (param[0] == 0x46 && (param[1] & 0xef) == 0x0f && param[2] < 40) + if ((param[0] & 0x0f) >= 0x06 && (param[1] & 0xaf) == 0x0f && + param[2] < 40) return true; for (i = 0; i < ARRAY_SIZE(rates); i++) -- 2.3.6