[2/3] input: stmpe-ts: Use devm_*() routines

Commit Message

Viresh Kumar Nov. 10, 2012, 8:03 a.m. UTC

On 10 November 2012 13:30, Dmitry Torokhov <[e-mail]> wrote:
> Sometimes your mailer does wrap long lines, please make sure to turn it
> off for patches.

I am using gmail for replying on mails and this fixup was done using that. Don't
know why it happened.

I am doing the same step again to verify what's playing with patches.
On this copy
i can see that this issue isn't there till now.

commit dda6d45808d65aaf8b0d4153e7a418b255365818
Author: Viresh Kumar <[e-mail]>
Date:   Fri Nov 9 22:28:26 2012 +0530

    fixup! input: stmpe-ts: Use devm_*() routines
---
 drivers/input/touchscreen/stmpe-ts.c | 2 --
 1 file changed, 2 deletions(-)


--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Viresh Kumar Nov. 10, 2012, 8:04 a.m. UTC | #1

On 10 November 2012 13:33, Viresh Kumar <[e-mail]> wrote:
> On 10 November 2012 13:30, Dmitry Torokhov <[e-mail]> wrote:
>> Sometimes your mailer does wrap long lines, please make sure to turn it
>> off for patches.
>
> I am using gmail for replying on mails and this fixup was done using that. Don't
> know why it happened.
>
> I am doing the same step again to verify what's playing with patches.
> On this copy
> i can see that this issue isn't there till now.
>
> diff --git a/drivers/input/touchscreen/stmpe-ts.c

> @@ -344,8 +344,6 @@ static int __devexit stmpe_ts_remove(struct
> platform_device *pdev)

wrapped again.. Don't know how to disable it. :(
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Dmitry Torokhov Nov. 10, 2012, 8:12 a.m. UTC | #2

On Sat, Nov 10, 2012 at 01:34:33PM +0530, Viresh Kumar wrote:
> On 10 November 2012 13:33, Viresh Kumar <[e-mail]> wrote:
> > On 10 November 2012 13:30, Dmitry Torokhov <[e-mail]> wrote:
> >> Sometimes your mailer does wrap long lines, please make sure to turn it
> >> off for patches.
> >
> > I am using gmail for replying on mails and this fixup was done using that. Don't
> > know why it happened.
> >
> > I am doing the same step again to verify what's playing with patches.
> > On this copy
> > i can see that this issue isn't there till now.
> >
> > diff --git a/drivers/input/touchscreen/stmpe-ts.c
> 
> > @@ -344,8 +344,6 @@ static int __devexit stmpe_ts_remove(struct
> > platform_device *pdev)
> 
> wrapped again.. Don't know how to disable it. :(

I just use mutt...

Hannes Frederic Sowa Nov. 10, 2012, 8:15 a.m. UTC | #3

On Sat, Nov 10, 2012 at 01:34:33PM +0530, Viresh Kumar wrote:
> wrapped again.. Don't know how to disable it. :(

To quote Documentation/email-clients.txt:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Gmail (Web GUI)

Does not work for sending patches.

Gmail web client converts tabs to spaces automatically.

At the same time it wraps lines every 78 chars with CRLF style line breaks
although tab2space problem can be solved with external editor.

Another problem is that Gmail will base64-encode any message that has a
non-ASCII character. That includes things like European names.

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/input/touchscreen/stmpe-ts.c
b/drivers/input/touchscreen/stmpe-ts.c
index 9896095..f2cb15d 100644
--- a/drivers/input/touchscreen/stmpe-ts.c
+++ b/drivers/input/touchscreen/stmpe-ts.c
@@ -344,8 +344,6 @@  static int __devexit stmpe_ts_remove(struct
platform_device *pdev)

        stmpe_disable(ts->stmpe, STMPE_BLOCK_TOUCHSCREEN);

-       input_unregister_device(ts->idev);
-
        return 0;
 }