| Message ID | 20171020210913.64498-1-dtwlin@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2017-10-21 6:09 GMT+09:00 David Lin <dtwlin@google.com>: > We should avoid using the space character when passing arguments to > clang, because static code analysis check tool such as sparse may > misinterpret the arguments followed by spaces as build targets hence > cause the build to fail. > > Signed-off-by: David Lin <dtwlin@google.com> > --- > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 05f95df0a247..c8819d0de907 100644 > --- a/Makefile > +++ b/Makefile > @@ -685,11 +685,11 @@ KBUILD_CFLAGS += $(stackp-flag) > > ifeq ($(cc-name),clang) > ifneq ($(CROSS_COMPILE),) > -CLANG_TARGET := -target $(notdir $(CROSS_COMPILE:%-=%)) > +CLANG_TARGET := --target=$(notdir $(CROSS_COMPILE:%-=%)) > GCC_TOOLCHAIN := $(realpath $(dir $(shell which $(LD)))/..) > endif > ifneq ($(GCC_TOOLCHAIN),) > -CLANG_GCC_TC := -gcc-toolchain $(GCC_TOOLCHAIN) > +CLANG_GCC_TC := --gcc-toolchain=$(GCC_TOOLCHAIN) > endif > KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) > KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) > -- > 2.15.0.rc0.271.g36b669edcc-goog > Applied to linux-kbuild/fixes. Thanks!
diff --git a/Makefile b/Makefile index 05f95df0a247..c8819d0de907 100644 --- a/Makefile +++ b/Makefile @@ -685,11 +685,11 @@ KBUILD_CFLAGS += $(stackp-flag) ifeq ($(cc-name),clang) ifneq ($(CROSS_COMPILE),) -CLANG_TARGET := -target $(notdir $(CROSS_COMPILE:%-=%)) +CLANG_TARGET := --target=$(notdir $(CROSS_COMPILE:%-=%)) GCC_TOOLCHAIN := $(realpath $(dir $(shell which $(LD)))/..) endif ifneq ($(GCC_TOOLCHAIN),) -CLANG_GCC_TC := -gcc-toolchain $(GCC_TOOLCHAIN) +CLANG_GCC_TC := --gcc-toolchain=$(GCC_TOOLCHAIN) endif KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)
We should avoid using the space character when passing arguments to clang, because static code analysis check tool such as sparse may misinterpret the arguments followed by spaces as build targets hence cause the build to fail. Signed-off-by: David Lin <dtwlin@google.com> --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)