| Message ID | 20220915150324.688062-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: Switch to use dev_err_probe() helper | expand |
Hi Yang, On Thu, Sep 15, 2022 at 11:03:11PM +0800, Yang Yingliang wrote: > In the probe path, dev_err() can be replace with dev_err_probe() > which will check if error code is -EPROBE_DEFER. It will print > error code in a human readable way and simplify the code. How would you like to get this merged ? A few patches need fixes, and all of them could benefit from a typo fix in the commit message. If you send a v2, it could be merged in one go instead of individual maintainers taking patches in their tree. Hans, would you handle this ? > Yang Yingliang (13): > media: platform: stm32-cec: Switch to use dev_err_probe() helper > media: i2c: ad5820: Switch to use dev_err_probe() helper > media: i2c: imx274: Switch to use dev_err_probe() helper > media: i2c: tc358743: Switch to use dev_err_probe() helper > media: platform: mtk_mdp_comp: Switch to use dev_err_probe() helper > media: platform: exynos4-is: Switch to use dev_err_probe() helper > media: stm32-dcmi: Switch to use dev_err_probe() helper > media: omap3isp: Switch to use dev_err_probe() helper > media: xilinx: csi2rxss: Switch to use dev_err_probe() helper > media: rc: gpio-ir-recv: Switch to use dev_err_probe() helper > media: rc: gpio-ir-tx: Switch to use dev_err_probe() helper > media: rc: ir-rx51: Switch to use dev_err_probe() helper > media: uvcvideo: Switch to use dev_err_probe() helper > > drivers/media/cec/platform/stm32/stm32-cec.c | 9 +++---- > drivers/media/i2c/ad5820.c | 18 +++++-------- > drivers/media/i2c/imx274.c | 5 ++-- > drivers/media/i2c/tc358743.c | 9 +++---- > .../platform/mediatek/mdp/mtk_mdp_comp.c | 5 ++-- > .../platform/samsung/exynos4-is/media-dev.c | 4 +-- > drivers/media/platform/st/stm32/stm32-dcmi.c | 27 +++++++------------ > drivers/media/platform/ti/omap3isp/isp.c | 3 +-- > .../media/platform/xilinx/xilinx-csi2rxss.c | 8 +++--- > drivers/media/rc/gpio-ir-recv.c | 10 +++---- > drivers/media/rc/gpio-ir-tx.c | 9 +++---- > drivers/media/rc/ir-rx51.c | 9 ++----- > drivers/media/usb/uvc/uvc_driver.c | 9 +++---- > 13 files changed, 41 insertions(+), 84 deletions(-)
On 2022/9/19 22:42, Laurent Pinchart wrote: > Hi Yang, > > On Thu, Sep 15, 2022 at 11:03:11PM +0800, Yang Yingliang wrote: >> In the probe path, dev_err() can be replace with dev_err_probe() >> which will check if error code is -EPROBE_DEFER. It will print >> error code in a human readable way and simplify the code. > How would you like to get this merged ? A few patches need fixes, and > all of them could benefit from a typo fix in the commit message. If you > send a v2, it could be merged in one go instead of individual > maintainers taking patches in their tree. Hans, would you handle this ? OK, I can merge them in one and send a v2. Thanks, Yang > >> Yang Yingliang (13): >> media: platform: stm32-cec: Switch to use dev_err_probe() helper >> media: i2c: ad5820: Switch to use dev_err_probe() helper >> media: i2c: imx274: Switch to use dev_err_probe() helper >> media: i2c: tc358743: Switch to use dev_err_probe() helper >> media: platform: mtk_mdp_comp: Switch to use dev_err_probe() helper >> media: platform: exynos4-is: Switch to use dev_err_probe() helper >> media: stm32-dcmi: Switch to use dev_err_probe() helper >> media: omap3isp: Switch to use dev_err_probe() helper >> media: xilinx: csi2rxss: Switch to use dev_err_probe() helper >> media: rc: gpio-ir-recv: Switch to use dev_err_probe() helper >> media: rc: gpio-ir-tx: Switch to use dev_err_probe() helper >> media: rc: ir-rx51: Switch to use dev_err_probe() helper >> media: uvcvideo: Switch to use dev_err_probe() helper >> >> drivers/media/cec/platform/stm32/stm32-cec.c | 9 +++---- >> drivers/media/i2c/ad5820.c | 18 +++++-------- >> drivers/media/i2c/imx274.c | 5 ++-- >> drivers/media/i2c/tc358743.c | 9 +++---- >> .../platform/mediatek/mdp/mtk_mdp_comp.c | 5 ++-- >> .../platform/samsung/exynos4-is/media-dev.c | 4 +-- >> drivers/media/platform/st/stm32/stm32-dcmi.c | 27 +++++++------------ >> drivers/media/platform/ti/omap3isp/isp.c | 3 +-- >> .../media/platform/xilinx/xilinx-csi2rxss.c | 8 +++--- >> drivers/media/rc/gpio-ir-recv.c | 10 +++---- >> drivers/media/rc/gpio-ir-tx.c | 9 +++---- >> drivers/media/rc/ir-rx51.c | 9 ++----- >> drivers/media/usb/uvc/uvc_driver.c | 9 +++---- >> 13 files changed, 41 insertions(+), 84 deletions(-)