| Message ID | 20220131144529.129096-2-jacopo@jmondi.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: ov5640: Rework the clock tree programming for MIPI | expand |
Hi Jacopo, Thank you for the patch. On Mon, Jan 31, 2022 at 03:45:28PM +0100, Jacopo Mondi wrote: > The driver already supports the 2X8_[LE|BE] variants of RGB565 > formats. > > As for CSI-2 the 2X8 variants do not apply, add RGB565_1X16 variant > with little-endian ordering of components as required by the CSI-2 > specifications. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > drivers/media/i2c/ov5640.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c > index 9d6eb3288b07..db77cdb8a958 100644 > --- a/drivers/media/i2c/ov5640.c > +++ b/drivers/media/i2c/ov5640.c > @@ -197,6 +197,7 @@ static const struct ov5640_pixfmt { > { MEDIA_BUS_FMT_YUYV8_1X16, V4L2_COLORSPACE_SRGB, 16,}, > { MEDIA_BUS_FMT_RGB565_2X8_LE, V4L2_COLORSPACE_SRGB, 16}, > { MEDIA_BUS_FMT_RGB565_2X8_BE, V4L2_COLORSPACE_SRGB, 16}, > + { MEDIA_BUS_FMT_RGB565_1X16, V4L2_COLORSPACE_SRGB, 16}, Should/could we limit this format to CSI-2 mode ? > { MEDIA_BUS_FMT_SBGGR8_1X8, V4L2_COLORSPACE_SRGB, 8}, > { MEDIA_BUS_FMT_SGBRG8_1X8, V4L2_COLORSPACE_SRGB, 8}, > { MEDIA_BUS_FMT_SGRBG8_1X8, V4L2_COLORSPACE_SRGB, 8}, > @@ -2746,6 +2747,7 @@ static int ov5640_set_framefmt(struct ov5640_dev *sensor, > mux = OV5640_FMT_MUX_YUV422; > break; > case MEDIA_BUS_FMT_RGB565_2X8_LE: > + case MEDIA_BUS_FMT_RGB565_1X16: > /* RGB565 {g[2:0],b[4:0]},{r[4:0],g[5:3]} */ > fmt = 0x6F; > mux = OV5640_FMT_MUX_RGB;
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index 9d6eb3288b07..db77cdb8a958 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -197,6 +197,7 @@ static const struct ov5640_pixfmt { { MEDIA_BUS_FMT_YUYV8_1X16, V4L2_COLORSPACE_SRGB, 16,}, { MEDIA_BUS_FMT_RGB565_2X8_LE, V4L2_COLORSPACE_SRGB, 16}, { MEDIA_BUS_FMT_RGB565_2X8_BE, V4L2_COLORSPACE_SRGB, 16}, + { MEDIA_BUS_FMT_RGB565_1X16, V4L2_COLORSPACE_SRGB, 16}, { MEDIA_BUS_FMT_SBGGR8_1X8, V4L2_COLORSPACE_SRGB, 8}, { MEDIA_BUS_FMT_SGBRG8_1X8, V4L2_COLORSPACE_SRGB, 8}, { MEDIA_BUS_FMT_SGRBG8_1X8, V4L2_COLORSPACE_SRGB, 8}, @@ -2746,6 +2747,7 @@ static int ov5640_set_framefmt(struct ov5640_dev *sensor, mux = OV5640_FMT_MUX_YUV422; break; case MEDIA_BUS_FMT_RGB565_2X8_LE: + case MEDIA_BUS_FMT_RGB565_1X16: /* RGB565 {g[2:0],b[4:0]},{r[4:0],g[5:3]} */ fmt = 0x6F; mux = OV5640_FMT_MUX_RGB;
The driver already supports the 2X8_[LE|BE] variants of RGB565 formats. As for CSI-2 the 2X8 variants do not apply, add RGB565_1X16 variant with little-endian ordering of components as required by the CSI-2 specifications. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- drivers/media/i2c/ov5640.c | 2 ++ 1 file changed, 2 insertions(+)