| Message ID | 20220131144529.129096-3-jacopo@jmondi.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: ov5640: Rework the clock tree programming for MIPI | expand |
Hi Jacopo, Thank you for the patch. On Mon, Jan 31, 2022 at 03:45:29PM +0100, Jacopo Mondi wrote: > Add support for RGB888/BGR888 image formats. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > drivers/media/i2c/ov5640.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c > index db77cdb8a958..5891eaab05ee 100644 > --- a/drivers/media/i2c/ov5640.c > +++ b/drivers/media/i2c/ov5640.c > @@ -198,6 +198,8 @@ static const struct ov5640_pixfmt { > { MEDIA_BUS_FMT_RGB565_2X8_LE, V4L2_COLORSPACE_SRGB, 16}, > { MEDIA_BUS_FMT_RGB565_2X8_BE, V4L2_COLORSPACE_SRGB, 16}, > { MEDIA_BUS_FMT_RGB565_1X16, V4L2_COLORSPACE_SRGB, 16}, > + { MEDIA_BUS_FMT_RGB888_1X24, V4L2_COLORSPACE_SRGB, 24}, > + { MEDIA_BUS_FMT_BGR888_1X24, V4L2_COLORSPACE_SRGB, 24}, If we can limit MEDIA_BUS_FMT_RGB565_1X16 to CSI-2 mode in the previous patch, then this should be limited too. The rest of the patch looks fine, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > { MEDIA_BUS_FMT_SBGGR8_1X8, V4L2_COLORSPACE_SRGB, 8}, > { MEDIA_BUS_FMT_SGBRG8_1X8, V4L2_COLORSPACE_SRGB, 8}, > { MEDIA_BUS_FMT_SGRBG8_1X8, V4L2_COLORSPACE_SRGB, 8}, > @@ -2757,6 +2759,16 @@ static int ov5640_set_framefmt(struct ov5640_dev *sensor, > fmt = 0x61; > mux = OV5640_FMT_MUX_RGB; > break; > + case MEDIA_BUS_FMT_RGB888_1X24: > + /* RGB888: BGR */ > + fmt = 0x22; > + mux = OV5640_FMT_MUX_RGB; > + break; > + case MEDIA_BUS_FMT_BGR888_1X24: > + /* BGR888: RGB */ > + fmt = 0x23; > + mux = OV5640_FMT_MUX_RGB; > + break; > case MEDIA_BUS_FMT_JPEG_1X8: > /* YUV422, YUYV */ > fmt = 0x30;
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index db77cdb8a958..5891eaab05ee 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -198,6 +198,8 @@ static const struct ov5640_pixfmt { { MEDIA_BUS_FMT_RGB565_2X8_LE, V4L2_COLORSPACE_SRGB, 16}, { MEDIA_BUS_FMT_RGB565_2X8_BE, V4L2_COLORSPACE_SRGB, 16}, { MEDIA_BUS_FMT_RGB565_1X16, V4L2_COLORSPACE_SRGB, 16}, + { MEDIA_BUS_FMT_RGB888_1X24, V4L2_COLORSPACE_SRGB, 24}, + { MEDIA_BUS_FMT_BGR888_1X24, V4L2_COLORSPACE_SRGB, 24}, { MEDIA_BUS_FMT_SBGGR8_1X8, V4L2_COLORSPACE_SRGB, 8}, { MEDIA_BUS_FMT_SGBRG8_1X8, V4L2_COLORSPACE_SRGB, 8}, { MEDIA_BUS_FMT_SGRBG8_1X8, V4L2_COLORSPACE_SRGB, 8}, @@ -2757,6 +2759,16 @@ static int ov5640_set_framefmt(struct ov5640_dev *sensor, fmt = 0x61; mux = OV5640_FMT_MUX_RGB; break; + case MEDIA_BUS_FMT_RGB888_1X24: + /* RGB888: BGR */ + fmt = 0x22; + mux = OV5640_FMT_MUX_RGB; + break; + case MEDIA_BUS_FMT_BGR888_1X24: + /* BGR888: RGB */ + fmt = 0x23; + mux = OV5640_FMT_MUX_RGB; + break; case MEDIA_BUS_FMT_JPEG_1X8: /* YUV422, YUYV */ fmt = 0x30;
Add support for RGB888/BGR888 image formats. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- drivers/media/i2c/ov5640.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)