diff mbox series

[v4,17/32] media: ov2680: Add support for ACPI enumeration

Message ID 20230802173046.368434-18-hdegoede@redhat.com (mailing list archive)
State New, archived
Headers show
Series media: ov2680: Bugfixes + ACPI + selection(crop-tgt) API support | expand

Commit Message

Hans de Goede Aug. 2, 2023, 5:30 p.m. UTC 
Add an acpi_match_table now that all the other bits necessary for
ACPI support are in place.

Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/media/i2c/ov2680.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Andy Shevchenko Aug. 2, 2023, 7:31 p.m. UTC | #1 
On Wed, Aug 2, 2023 at 8:31 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Add an acpi_match_table now that all the other bits necessary for
> ACPI support are in place.

Would be good to add a couple of words about ID itself:
- is it the correct ACPI ID or not (confirmation from OmniVision, if any)?
- is there a product with that ID in the wild (mention, if any)?
Hans de Goede Aug. 3, 2023, 9:14 a.m. UTC | #2 
Hi,

On 8/2/23 21:31, Andy Shevchenko wrote:
> On Wed, Aug 2, 2023 at 8:31 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Add an acpi_match_table now that all the other bits necessary for
>> ACPI support are in place.
> 
> Would be good to add a couple of words about ID itself:
> - is it the correct ACPI ID or not (confirmation from OmniVision, if any)?
> - is there a product with that ID in the wild (mention, if any)?

Ok, I'll add some text about this to the commit msg for v5.

Regards,

Hans
diff mbox series

Patch

diff --git a/drivers/media/i2c/ov2680.c b/drivers/media/i2c/ov2680.c
index d4664581b49b..0adfacc70735 100644
--- a/drivers/media/i2c/ov2680.c
+++ b/drivers/media/i2c/ov2680.c
@@ -932,11 +932,18 @@  static const struct of_device_id ov2680_dt_ids[] = {
 };
 MODULE_DEVICE_TABLE(of, ov2680_dt_ids);
 
+static const struct acpi_device_id ov2680_acpi_ids[] = {
+	{ "OVTI2680" },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(acpi, ov2680_acpi_ids);
+
 static struct i2c_driver ov2680_i2c_driver = {
 	.driver = {
 		.name  = "ov2680",
 		.pm = pm_sleep_ptr(&ov2680_pm_ops),
 		.of_match_table	= ov2680_dt_ids,
+		.acpi_match_table = ov2680_acpi_ids,
 	},
 	.probe		= ov2680_probe,
 	.remove		= ov2680_remove,