: gspca: use usb interface as parent

Commit Message

Hans de Goede March 27, 2009, 9:35 a.m. UTC

Hi all,

As discussed in the:
"v4l parent for usb device interface or device?"
thread, here is a patch for gspca to make it use
the usb interface as its parent device, instead
of the usb device.

Regards,

Hans

p.s.

I'll also push a patch to my libv4l repo, with
matching libv4l changes so that libv4l's upside
down cam detections stays working with this change.

Note: this libv4l patch also fixes libv4l upside
down detection for the new device numbering style.

Comments

Jean-Francois Moine March 27, 2009, 7:05 p.m. UTC | #1

On Fri, 27 Mar 2009 10:35:43 +0100
Hans de Goede <[e-mail]> wrote:

> Hi all,

Hi Hans,

> As discussed in the:
> "v4l parent for usb device interface or device?"
> thread, here is a patch for gspca to make it use
> the usb interface as its parent device, instead
> of the usb device.
	[snip]

Applied, thanks.

This patch may solve the microphone problem that some people have...

Cheers.

Patch

diff -r c28651a2c2c3 linux/drivers/media/video/gspca/gspca.c
--- a/linux/drivers/media/video/gspca/gspca.c	Thu Mar 26 09:44:15 2009 +0100
+++ b/linux/drivers/media/video/gspca/gspca.c	Fri Mar 27 10:32:24 2009 +0100
@@ -1958,7 +1958,7 @@ 
 
 	/* init video stuff */
 	memcpy(&gspca_dev->vdev, &gspca_template, sizeof gspca_template);
-	gspca_dev->vdev.parent = &dev->dev;
+	gspca_dev->vdev.parent = &intf->dev;
 	gspca_dev->module = module;
 	gspca_dev->present = 1;
 	ret = video_register_device(&gspca_dev->vdev,