| Message ID | 20231023-display-support-v1-2-5c860ed5c33b@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add display support for the MT8365-EVK board | expand |
On Mon, Oct 23, 2023 at 04:40:02PM +0200, Alexandre Mergnat wrote: > Display Color Correction for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. This commit message's first line is too vague & the second doesn't make sense. I suspect something as succinct as "Document the display colour correction on mt<foo>, which is compatible with that of the mt<bar>" does what you are looking for. I suspect this is going to apply to the rest of the series... Cheers, Conor. > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > index 8c2a737237f2..9f8366763831 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > @@ -24,6 +24,9 @@ properties: > - enum: > - mediatek,mt8183-disp-ccorr > - mediatek,mt8192-disp-ccorr > + - items: > + - const: mediatek,mt8365-disp-ccorr > + - const: mediatek,mt8183-disp-ccorr > - items: > - enum: > - mediatek,mt8186-disp-ccorr > > -- > 2.25.1 >
On Mon, Oct 23, 2023 at 06:31:45PM +0100, Conor Dooley wrote: > On Mon, Oct 23, 2023 at 04:40:02PM +0200, Alexandre Mergnat wrote: > > Display Color Correction for MT8365 is compatible with another SoC. > > Then, add MT8365 binding along with MT8183 SoC. > > This commit message's first line is too vague & the second doesn't make > sense. I suspect something as succinct as "Document the display colour > correction on mt<foo>, which is compatible with that of the mt<bar>" > does what you are looking for. > > I suspect this is going to apply to the rest of the series... It does, as does the comment about s/binding/compatible/ I left on patch 1. > > Cheers, > Conor. > > > > > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > > --- > > Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > > index 8c2a737237f2..9f8366763831 100644 > > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > > @@ -24,6 +24,9 @@ properties: > > - enum: > > - mediatek,mt8183-disp-ccorr > > - mediatek,mt8192-disp-ccorr > > + - items: > > + - const: mediatek,mt8365-disp-ccorr > > + - const: mediatek,mt8183-disp-ccorr > > - items: > > - enum: > > - mediatek,mt8186-disp-ccorr > > > > -- > > 2.25.1 > >
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml index 8c2a737237f2..9f8366763831 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml @@ -24,6 +24,9 @@ properties: - enum: - mediatek,mt8183-disp-ccorr - mediatek,mt8192-disp-ccorr + - items: + - const: mediatek,mt8365-disp-ccorr + - const: mediatek,mt8183-disp-ccorr - items: - enum: - mediatek,mt8186-disp-ccorr
Display Color Correction for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 3 +++ 1 file changed, 3 insertions(+)