| Message ID | 20231215104551.233679-3-eugen.hristev@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/7] media: mediatek: vcodec: fix possible unbalanced PM counter | expand |
On Fri, 15 Dec 2023 12:45:47 +0200, Eugen Hristev wrote: > Looking at the binding it makes sense that the `-vp8` compatible has > the `venc_lt_sel` while the other bindings have the `venc_sel` as name for > the clock. > This was also mentioned in the txt version of the binding before the > conversion: > ` > clock-names: avc encoder must contain "venc_sel", vp8 encoder must > contain "venc_lt_sel", decoder must contain "vcodecpll", "univpll_d2", > ` > > So it is easier to check for compatible that includes vp8, since that's > just one, to have the requirement for the clock name property as > `venc_lt_sel`, rather than for all the others, some of which are missing, > thus for them, the requirement is wrongly `venc_lt_sel`. > > Reordered the if/then/else to match `-vp8` and have all the rest of > the compatibles using the other clock name (`venc_sel`). > > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > --- > Changes in v2: > - new patch. > .../bindings/media/mediatek,vcodec-encoder.yaml | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml index 403530de5624..5166c1c6934e 100644 --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml @@ -111,10 +111,7 @@ allOf: properties: compatible: enum: - - mediatek,mt8173-vcodec-enc - - mediatek,mt8188-vcodec-enc - - mediatek,mt8192-vcodec-enc - - mediatek,mt8195-vcodec-enc + - mediatek,mt8173-vcodec-enc-vp8 then: properties: @@ -124,8 +121,8 @@ allOf: maxItems: 1 clock-names: items: - - const: venc_sel - else: # for vp8 hw encoder + - const: venc_lt_sel + else: properties: clock: items: @@ -133,7 +130,7 @@ allOf: maxItems: 1 clock-names: items: - - const: venc_lt_sel + - const: venc_sel additionalProperties: false
Looking at the binding it makes sense that the `-vp8` compatible has the `venc_lt_sel` while the other bindings have the `venc_sel` as name for the clock. This was also mentioned in the txt version of the binding before the conversion: ` clock-names: avc encoder must contain "venc_sel", vp8 encoder must contain "venc_lt_sel", decoder must contain "vcodecpll", "univpll_d2", ` So it is easier to check for compatible that includes vp8, since that's just one, to have the requirement for the clock name property as `venc_lt_sel`, rather than for all the others, some of which are missing, thus for them, the requirement is wrongly `venc_lt_sel`. Reordered the if/then/else to match `-vp8` and have all the rest of the compatibles using the other clock name (`venc_sel`). Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> --- Changes in v2: - new patch. .../bindings/media/mediatek,vcodec-encoder.yaml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)