| Message ID | f04ba92a958abe0051be7ce3202f6361cb0f05f2.1649443080.git.hns@goldelico.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | MIPS: DTS: fix some findings by "make ci20_defconfig dt_binding_check dtbs_check" | expand |
On 08/04/2022 20:37, H. Nikolaus Schaller wrote: > arch/mips/boot/dts/ingenic/ci20.dtb: /: fixedregulator@0: 'anyOf' conditional failed, one must be fixed: > 'reg' is a required property > 'ranges' is a required property > From schema: python/site-packages/dtschema/schemas/root-node.yaml > arch/mips/boot/dts/ingenic/ci20.dtb: /: fixedregulator@1: 'anyOf' conditional failed, one must be fixed: > 'reg' is a required property > 'ranges' is a required property > From schema: python/site-packages/dtschema/schemas/root-node.yaml > arch/mips/boot/dts/ingenic/ci20.dtb: /: fixedregulator@2: 'anyOf' conditional failed, one must be fixed: > 'reg' is a required property > 'ranges' is a required property > From schema: python/site-packages/dtschema/schemas/root-node.yaml > > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > arch/mips/boot/dts/ingenic/ci20.dts | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts > index cb5257d32b55e..c045c4f75895e 100644 > --- a/arch/mips/boot/dts/ingenic/ci20.dts > +++ b/arch/mips/boot/dts/ingenic/ci20.dts > @@ -69,7 +69,7 @@ led3 { > }; > }; > > - eth0_power: fixedregulator@0 { > + eth0_power: eth3v3 { No, Devicetree spec requires generic node name, so "regulator-0" is appropriate. See also examples of device tree node names in the spec. "eth3v3" is a specific one, not generic. Best regards, Krzysztof
diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts index cb5257d32b55e..c045c4f75895e 100644 --- a/arch/mips/boot/dts/ingenic/ci20.dts +++ b/arch/mips/boot/dts/ingenic/ci20.dts @@ -69,7 +69,7 @@ led3 { }; }; - eth0_power: fixedregulator@0 { + eth0_power: eth3v3 { compatible = "regulator-fixed"; regulator-name = "eth0_power"; @@ -99,7 +99,7 @@ ir: ir { gpios = <&gpe 3 GPIO_ACTIVE_LOW>; }; - wlan0_power: fixedregulator@1 { + wlan0_power: wlan_power { compatible = "regulator-fixed"; regulator-name = "wlan0_power"; @@ -108,7 +108,7 @@ wlan0_power: fixedregulator@1 { enable-active-high; }; - otg_power: fixedregulator@2 { + otg_power: otg5v0 { compatible = "regulator-fixed"; regulator-name = "otg_power";
arch/mips/boot/dts/ingenic/ci20.dtb: /: fixedregulator@0: 'anyOf' conditional failed, one must be fixed: 'reg' is a required property 'ranges' is a required property From schema: python/site-packages/dtschema/schemas/root-node.yaml arch/mips/boot/dts/ingenic/ci20.dtb: /: fixedregulator@1: 'anyOf' conditional failed, one must be fixed: 'reg' is a required property 'ranges' is a required property From schema: python/site-packages/dtschema/schemas/root-node.yaml arch/mips/boot/dts/ingenic/ci20.dtb: /: fixedregulator@2: 'anyOf' conditional failed, one must be fixed: 'reg' is a required property 'ranges' is a required property From schema: python/site-packages/dtschema/schemas/root-node.yaml Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- arch/mips/boot/dts/ingenic/ci20.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)