[144/166] kallsyms: unexport kallsyms_lookup_name() and kallsyms_on_each_symbol()

Commit Message

Andrew Morton April 7, 2020, 3:11 a.m. UTC

From: Will Deacon <[e-mail]>
Subject: kallsyms: unexport kallsyms_lookup_name() and kallsyms_on_each_symbol()

kallsyms_lookup_name() and kallsyms_on_each_symbol() are exported to
modules despite having no in-tree users and being wide open to abuse by
out-of-tree modules that can use them as a method to invoke arbitrary
non-exported kernel functions.

Unexport kallsyms_lookup_name() and kallsyms_on_each_symbol().

Link: http://lkml.kernel.org/r/[e-mail]
Signed-off-by: Will Deacon <[e-mail]>
Reviewed-by: Greg Kroah-Hartman <[e-mail]>
Reviewed-by: Christoph Hellwig <[e-mail]>
Acked-by: Alexei Starovoitov <[e-mail]>
Reviewed-by: Masami Hiramatsu <[e-mail]>
Reviewed-by: Quentin Perret <[e-mail]>
Cc: Thomas Gleixner <[e-mail]>
Cc: Frederic Weisbecker <[e-mail]>
Cc: K.Prasad <[e-mail]>
Cc: Miroslav Benes <[e-mail]>
Cc: Petr Mladek <[e-mail]>
Cc: Joe Lawrence <[e-mail]>
Cc: Mathieu Desnoyers <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 kernel/kallsyms.c |    2 --
 1 file changed, 2 deletions(-)

Patch

--- a/kernel/kallsyms.c~kallsyms-unexport-kallsyms_lookup_name-and-kallsyms_on_each_symbol
+++ a/kernel/kallsyms.c
@@ -175,7 +175,6 @@  unsigned long kallsyms_lookup_name(const
 	}
 	return module_kallsyms_lookup_name(name);
 }
-EXPORT_SYMBOL_GPL(kallsyms_lookup_name);
 
 int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *,
 				      unsigned long),
@@ -194,7 +193,6 @@  int kallsyms_on_each_symbol(int (*fn)(vo
 	}
 	return module_kallsyms_on_each_symbol(fn, data);
 }
-EXPORT_SYMBOL_GPL(kallsyms_on_each_symbol);
 
 static unsigned long get_symbol_pos(unsigned long addr,
 				    unsigned long *symbolsize,